Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cardano cleanup backwards compatibility branches #10504

Closed
mroz22 opened this issue Jan 5, 2024 · 1 comment · Fixed by #10543
Closed

cardano cleanup backwards compatibility branches #10504

mroz22 opened this issue Jan 5, 2024 · 1 comment · Fixed by #10543
Assignees
@marekrjpolak
Labels
code Code improvements

Comments

@mroz22
Copy link
Contributor

mroz22 commented Jan 5, 2024

we are bumping min fw version in connect to 2.4.3 for cardano methods in #10493

there are numerous backwards compatibilty code branches that can now be removed.
@mroz22 mroz22 added the code Code improvements label Jan 5, 2024
@marekrjpolak marekrjpolak mentioned this issue Jan 8, 2024
Merged
@github-project-automation github-project-automation bot moved this to 🤝 Needs QA in Suite Desktop May 23, 2024
@bosomt
Copy link
Contributor

bosomt commented Jun 18, 2024

QA OK

cardano and tests cardano claiming/staking/sending/receiving
works as expected with current 2.7.3 FW

2.4.0 fw reports Firmware update required

Info:

  • Suite version: desktop 24.6.1 (9d8fc58)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.6.1 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.4.0 regular (revision ea3596ad8)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marekrjpolak marekrjpolak

Labels
code Code improvements
Projects
Suite Desktop
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Cardano <2.4.3 compatibility branches trezor/trezor-suite
3 participants
@marekrjpolak @mroz22 @bosomt