Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cardano <2.4.3 compatibility branches #10543

Merged
merged 6 commits into from
May 23, 2024

Conversation

marekrjpolak
Copy link
Contributor

@marekrjpolak marekrjpolak commented Jan 8, 2024

Description

As 2.4.3 fw is required for Cardano since previous PR, we can remove correspondent backward compatibility code branches.

Related Issue

Resolve #10504

@marekrjpolak marekrjpolak changed the base branch from develop to fix/ada-passphrase January 8, 2024 13:49
Base automatically changed from fix/ada-passphrase to develop January 12, 2024 10:21
@marekrjpolak
Copy link
Contributor Author

/rebase

Copy link

Copy link

Rebasing failed, please rebase manually.

@marekrjpolak marekrjpolak force-pushed the chore/ada-compatibility-cleanup branch from 3098170 to f6f9358 Compare January 12, 2024 13:42
@mroz22
Copy link
Contributor

mroz22 commented May 17, 2024

please @martykan take this burden off @marekrjpolak and finish this :D once you have time, no hurry here definitely.
what I see here missing is that we should bump required fw versions for cardano calls in config.ts

@martykan martykan force-pushed the chore/ada-compatibility-cleanup branch from f6f9358 to 7917815 Compare May 17, 2024 12:53
@martykan
Copy link
Member

martykan commented May 17, 2024

Maybe it's also a good time to get rid of this?

// todo: remove when listed firmwares become mandatory for cardanoSignTransaction
const CardanoSignTransactionFeatures = Object.freeze({
TransactionStreaming: ['0', '2.4.2'],
TokenMinting: ['0', '2.4.3'],
Multisig: ['0', '2.4.3'],
NetworkIdInTxBody: ['0', '2.4.4'],
OutputDatumHash: ['0', '2.4.4'],
ScriptDataHash: ['0', '2.4.4'],
Plutus: ['0', '2.4.4'],
KeyHashStakeCredential: ['0', '2.4.4'],
Babbage: ['0', '2.5.2'],
CIP36Registration: ['0', '2.5.3'],
CIP36RegistrationExternalPaymentAddress: ['0', '2.5.4'],
});

But we would have to bump higher, to 2.5.4

Edit: removed and bumped to 2.6.0

@martykan martykan force-pushed the chore/ada-compatibility-cleanup branch from d96917e to e7055f0 Compare May 20, 2024 14:47
@martykan martykan force-pushed the chore/ada-compatibility-cleanup branch from e7055f0 to 5f6a726 Compare May 20, 2024 14:49
@martykan martykan marked this pull request as ready for review May 20, 2024 15:24
@mroz22 mroz22 merged commit acd9e1e into develop May 23, 2024
63 checks passed
@mroz22 mroz22 deleted the chore/ada-compatibility-cleanup branch May 23, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🗒 Draft
Development

Successfully merging this pull request may close these issues.

cardano cleanup backwards compatibility branches
3 participants