Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph: Last touched point on graph is persisted through refresh + balance is taken from different device when view-only enabled #11231

Closed
sime opened this issue Feb 19, 2024 · 7 comments · Fixed by #12463 or #12469
Assignees
Labels
bug Something isn't working as expected mobile Suite Lite issues and PRs

Comments

@sime
Copy link
Contributor

sime commented Feb 19, 2024

Describe the bug
Last touched point on graph is persisted through refresh
When user has two devices in view-only and refreshes the dashboard, the balance is refreshed from the different device - see the video.

Info:

  • Mobile Suite Version: 24.3.1
  • OS: Android, 13

How to reproduce
Balance persisted on graph:

  1. Choose a point on the graph that is different from the portfolio balance
  2. Pull down to refresh
  3. Note the old selection price represented as the portfolio balance

Balance persisted from second device

  1. Have two devices in view-only
  2. refresh graph on dashboard on one
  3. The balance from the other one appears

Expected behaviour
Current portfolio balance to be visible

Screenshots
https://github.com/trezor/trezor-suite/assets/216917/20dd4053-e130-4738-8291-5533bfc27715
[

screen-20240517-113645.mp4

](url)

Additional context

@sime sime added bug Something isn't working as expected mobile Suite Lite issues and PRs labels Feb 19, 2024
@sime
Copy link
Contributor Author

sime commented Mar 4, 2024

Time selector shows the wrong portfolio balance after long pressing on the graph and changing the dates.

2024-03-04-12-46-45.mp4

@tsusanka
Copy link
Contributor

tsusanka commented Mar 18, 2024

Gotta say that this one is really annoying. I don't even think you need to refresh, it just happens after you switch to another view.

@mnuky mnuky moved this to 🎯 To do in Suite Mobile Mar 27, 2024
@mnuky mnuky removed the status in Suite Mobile Mar 27, 2024
@mnuky mnuky moved this to 🎯 To do in Suite Mobile Mar 27, 2024
@mnuky mnuky changed the title Graph: Last touched point on graph is persisted through refresh Graph: Last touched point on graph is persisted through refresh + balance is taken from different device when view-only enabled May 17, 2024
@matejkriz
Copy link
Member

With view-only, it happens also cross wallets 😞

@Nodonisko Nodonisko moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile May 17, 2024
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 👀 Dev done in Suite Mobile May 17, 2024
@mnuky mnuky moved this from 👀 Dev done to 🤝 Needs QA in Suite Mobile May 20, 2024
@STew790
Copy link
Contributor

STew790 commented May 23, 2024

I am not really sure if this is OK or not but I can see just for a split second still the persisted point on graph. Video below:

Uploading 1000011988.mp4…

@STew790
Copy link
Contributor

STew790 commented May 24, 2024

I don't know why the video didn't upload, lets hope this works:

1000011988.mp4

@matejkriz
Copy link
Member

@STew790 It's not a new bug, it is on current production. Could you please create a new bug issue for it to not block this one?

@STew790
Copy link
Contributor

STew790 commented May 24, 2024

Done.

QA OK

24.5.1 319a98a

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected mobile Suite Lite issues and PRs
Projects
Status: ✅ Approved
5 participants