Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mobile): fix graph old value on timeframe switch #12463

Merged
merged 1 commit into from
May 17, 2024
Merged

fix(mobile): fix graph old value on timeframe switch #12463

merged 1 commit into from
May 17, 2024

Conversation

Nodonisko
Copy link
Contributor

Description

onPointSelected callback was called everytime when loading was switched to false (ended) which is incorrect behavior.

Related Issue

Resolve #11231

Screenshots:

@Nodonisko Nodonisko requested a review from a team as a code owner May 17, 2024 12:35
juriczech
juriczech approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@juriczech juriczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test it though

@Nodonisko Nodonisko enabled auto-merge (squash) May 17, 2024 12:51
@Nodonisko Nodonisko merged commit 6b97cdb into develop May 17, 2024
12 checks passed
@Nodonisko Nodonisko deleted the fix/outdated-graph-value-on-switch branch May 17, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juriczech juriczech juriczech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Nodonisko @juriczech