Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XRP tx incorrectly mark as successful even though it failed #16281

Closed
tomasklim opened this issue Jan 9, 2025 · 1 comment · Fixed by #16550
Closed

XRP tx incorrectly mark as successful even though it failed #16281

tomasklim opened this issue Jan 9, 2025 · 1 comment · Fixed by #16550
Assignees
@izmy
Labels
bug Something isn't working as expected Ripple XRP

Comments

@tomasklim
Copy link
Member

How to reproduce
Steps to reproduce the behavior:

  1. Send money to address (rw2ciyaNshpHe7bCHo4bRWq6pqqynnWKQg) which requires destinationTag but do not specify this destinationTag in send form
  2. Tx fails according to notification
  3. Check explorer https://xrpscan.com/tx/BE4D883282BA4A16121117F382E916504D24AC90530F5575032E8F0E6A63E6C5 it is failed
  4. Check Suite tx history, it is ok but balance has not changed

How to resolve
Problem is probably in blockchain-link. I think we incorrectly mark failed tx as sent

Screenshots

Image
Image
Image
Image
Image
@tomasklim tomasklim added the bug Something isn't working as expected label Jan 9, 2025
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Jan 9, 2025
@tomasklim tomasklim assigned enjojoy and TomasBoda and unassigned enjojoy Jan 9, 2025
@tomasklim tomasklim assigned izmy and unassigned TomasBoda Jan 21, 2025
@tomasklim tomasklim added the Ripple XRP label Jan 21, 2025
@izmy izmy mentioned this issue Jan 22, 2025
Merged
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Suite Desktop Jan 30, 2025
@bosomt
Copy link
Contributor

bosomt commented Jan 31, 2025

QA OK

FAILED  The transaction did not specify a Destination tag, but the destination account has requireDestinationTag flag enabled and requires it.
Screenshot 2025-01-31 at 12 08 05 Screenshot 2025-01-31 at 12 08 01

Info:

  • Suite version: web 25.2.0 (a56381e)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T2T1 2.8.8 regular (revision bbcb920213b0ab847a2fedf825eac70652e33279)
  • Transport: WebUsbTransport

@bosomt bosomt removed the status in Suite Desktop Jan 31, 2025
@bosomt bosomt moved this to ✅ Approved in Suite Desktop Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@izmy izmy

Labels
bug Something isn't working as expected Ripple XRP
Projects
Suite Desktop
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

XRP: fix status in failed transactions with missing destination tag trezor/trezor-suite
5 participants
@izmy @bosomt @tomasklim @TomasBoda @enjojoy