XRP: fix status in failed transactions with missing destination tag #16550
+125
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasklim
reviewed
Jan 23, 2025
...ite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/BasicTxDetails.tsx
Outdated
Show resolved
Hide resolved
tomasklim
requested changes
Jan 23, 2025
tomasklim
requested changes
Jan 23, 2025
done |
tomasklim
approved these changes
Jan 27, 2025
|
/rebase |
…th missing destination tag
trezor-ci
force-pushed
the
fix/ripple-failed-transactions
branch
from
fceb9df to
33de843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suite incorrectly displayed success status in XRP transactions when destination tag was missing.
I also changed the color for the Confirmed status in transaction detail, because it could have been a confusing UX.
Related Issue
Resolve #16281
Screenshots: