Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(suite): rework transport section in debug settings #12342

Merged
merged 1 commit into from
May 13, 2024

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented May 10, 2024

Debug transport section reworked

Since I have encountered some confusions by @bosomt on how transport sections actually works I decided to rework it slightly.

This PR also resolves #12288.

Changes:

  • removed the "Processes" component from the debug menu. It has never been used for anything but toggling bridge process. The original ambition to have a common control panel for processes was not fulfilled.
  • added "Transport backend" section in place of "Processes". It has the same features but adds also ability to change the "startOnStartup" bridge settings and it newly implements the ability to opt-in for the legacy bridge as requested in Put bridge switcher into the debug menu #12288
  • what previously was named "Transports" section has now become "Transport clients" section to bring more clarity here. Also, descriptions of specific transport clients have been added.

Todo:

  • shouldn't suite-desktop-core become dependency of desktop-api in order to avoid types duplication?
  • shoudln't we add some common channel for store updates and data retrieval instead particular calls such as the here added bridge/get-status etc? This might be related to what @marekrjpolak is doing right now (the redux loading thing)

image

@mroz22 mroz22 force-pushed the debug-menu-tranpsport-rework branch 2 times, most recently from abf475f to 1067485 Compare May 10, 2024 16:33
@mroz22 mroz22 force-pushed the debug-menu-tranpsport-rework branch from 1067485 to 660aae2 Compare May 10, 2024 16:38
@mroz22 mroz22 marked this pull request as ready for review May 13, 2024 09:29
Copy link
Contributor

@marekrjpolak marekrjpolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it does what it should. Add automatic app reload or don't, and :shipit:

@mroz22
Copy link
Contributor Author

mroz22 commented May 13, 2024

hmm, lets merge it for now. making it more user-friendly and fool-proof could be useful but that can't be done as a followup

@mroz22 mroz22 merged commit a6a7a8f into develop May 13, 2024
21 checks passed
@mroz22 mroz22 deleted the debug-menu-tranpsport-rework branch May 13, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put bridge switcher into the debug menu
2 participants