fix(suite): Flex naming #12441
Merged
fix(suite): Flex naming #12441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvaclavik
force-pushed
the
fix-flex-naming
branch
2 times, most recently
from
5e8ee00 to
c49ec93
Compare
| {...makePropsTransient(frameProps)} | ||
| > | ||
| {children} | ||
| </Container> | ||
| ); | ||
| }; | ||
|
|
||
| export const Rows = (props: FlexProps) => <Flex {...props} direction="column" />; | ||
| export const Columns = (props: FlexProps) => <Flex {...props} direction="row" />; | ||
| export const Column = (props: FlexProps) => <Flex {...props} direction="column" />; |
There was a problem hiding this comment.
👏 I was bitten by this already :D This is much better
jvaclavik
force-pushed
the
fix-flex-naming
branch
from
c49ec93 to
e213ed7
Compare
peter-sanderson
approved these changes
May 16, 2024
jvaclavik
force-pushed
the
fix-flex-naming
branch
from
e213ed7 to
efdb174
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolve
Screenshots: