feat(suite-native): delete view only feature flag completely

[matejkriz]

Description

It is no more needed, and by this change it is also removed from persist store.

Acceptance criteria for QA:

• View only feature is now turned on for everyone, even for those updating from 24.4 version

Related Issue

Resolve #12013

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	orphan: npm/[email protected]
Network access	npm/[email protected]	Module: http Location: Package overview	orphan: npm/[email protected]
Network access	npm/[email protected]	Module: https Location: Package overview	orphan: npm/[email protected]
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	orphan: npm/[email protected]
Network access	npm/[email protected]	Module: net Location: Package overview	orphan: npm/[email protected]
Trivial Package	npm/[email protected]	Location: Package overview	Source
Non-existent author	npm/[email protected]	Location: Package overview	Source
Shell access	npm/[email protected]	Module: child_process Location: Package overview	Source
Shell access	npm/[email protected]	Module: child_process Location: Package overview	Source
New author	npm/[email protected]	New Author: dominicbarnes Previous Author: tootallnate	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
Trivial Package	npm/[email protected]	Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
Uses eval	npm/[email protected]	Eval Type: Function Location: Package overview	Source
Uses eval	npm/[email protected]	Eval Type: eval Location: Package overview	Source
Uses eval	npm/[email protected]	Eval Type: Function Location: Package overview	Source
Uses eval	npm/[email protected]	Eval Type: Function Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fs-extra Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	suite-common/icons/package.json
Shell access	npm/@react-native-community/[email protected]	Module: child_process Location: Package overview	orphan: npm/@react-native-community/[email protected]
Filesystem access	npm/@react-native-community/[email protected]	Module: fs Location: Package overview	orphan: npm/@react-native-community/[email protected]
Filesystem access	npm/@react-native-community/[email protected]	Module: fs-extra Location: Package overview	orphan: npm/@react-native-community/[email protected]
Filesystem access	npm/[email protected]	Module: fs/promises Location: Package overview	package.json scripts/package.json suite-native/video-assets/package.json
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	package.json scripts/package.json suite-native/video-assets/package.json
Native code	npm/[email protected]	Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fs-extra Location: Package overview	orphan: npm/[email protected]
Filesystem access	npm/[email protected]	Module: fs/promises Location: Package overview	orphan: npm/[email protected]
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
Uses eval	npm/[email protected]	Eval Type: Function Location: Package overview	Source
Network access	npm/[email protected]	Module: net Location: Package overview	Source
Network access	npm/[email protected]	Module: http Location: Package overview	Source
Shell access	npm/[email protected]	Module: child_process Location: Package overview	Source
Network access	npm/[email protected]	Module: https Location: Package overview	Source
Network access	npm/[email protected]	Module: tls Location: Package overview	Source
Floating dependency	npm/@types/[email protected]	Location: Package overview	orphan: npm/@types/[email protected]
Uses eval	npm/[email protected]	Eval Type: Function Location: Package overview	Source
Uses eval	npm/[email protected]	Eval Type: Function Location: Package overview	Source
Uses eval	npm/[email protected]	Eval Type: Function Location: Package overview	Source
Install scripts	npm/[email protected]	Install script: postinstall Source: node -e "try{require('./postinstall')}catch(e){}"	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source

View full report↗︎

Next steps

What is filesystem access?

Accesses the file system, and could potentially read sensitive data.

If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What are trivial packages?

Packages less than 10 lines of code are easily copied into your own project and may not warrant the additional supply chain risk of an external dependency.

Removing this package as a dependency and implementing its logic will reduce supply chain risk.

What is a non-existent author?

The package was published by an npm account that no longer exists.

Packages should have active and identified authors.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is eval?

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

What's wrong with native code?

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

What are floating dependencies?

Package has a dependency with a floating version range. This can cause issues if the dependency publishes a new major version.

Packages should specify properly semver ranges to avoid version conflicts.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/@react-native-community/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/@types/[email protected]
• @SocketSecurity ignore npm/[email protected]

[juriczech]

LGTM