fix(staking): zero amounts when bumping fee #15030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasklim
force-pushed
the
fix/staking-zero-amounts-when-bumping-fee
branch
from
51e001e to
6ada92e
Compare
tomasklim
approved these changes
Oct 23, 2024
tomasklim
force-pushed
the
fix/staking-zero-amounts-when-bumping-fee
branch
2 times, most recently
from
ec65227 to
98029fd
Compare
Closed
tomasklim
requested changes
Oct 23, 2024
|
this fixup 2090878 hides zero amount for bump txs when claiming as was agreed |
|
Hey, @tomasklim |
|
@omykhailovskyi don't worry, the last commit is quite a big change and I wanted to go through really carefully |
tomasklim
force-pushed
the
fix/staking-zero-amounts-when-bumping-fee
branch
3 times, most recently
from
fe65440 to
482fff9
Compare
Closed
tomasklim
approved these changes
Nov 3, 2024
tomasklim
force-pushed
the
fix/staking-zero-amounts-when-bumping-fee
branch
from
482fff9 to
557db07
Compare
martykan
reviewed
Nov 3, 2024
| @@ -362,7 +362,7 @@ export const formatAmount = (amount: BigNumberValue, decimals: number) => { | |||
| } | |||
| }; | |||
|
|
|||
| export const amountToSatoshi = (amount: BigNumberValue, decimals: number) => { | |||
| export const formatAmountWithDecimals = (amount: BigNumberValue, decimals: number) => { | |||
There was a problem hiding this comment.
Just a nitpick, but I think the new name makes it unclear what this function does.
It's named confusingly similarly to formatAmount function, but it does the opposite thing.
So maybe amountToSmallestUnit or normalizeAmount?
There was a problem hiding this comment.
It is clear for me, but I will rename it. np
tomasklim
force-pushed
the
fix/staking-zero-amounts-when-bumping-fee
branch
from
557db07 to
973274f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolve #13752
Resolve #13397
Screenshots: