fix: remove sudo auto-install of the udevrules, simplify it #15076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-sanderson
force-pushed
the
udev-rules
branch
from
54a6282 to
efe34a9
Compare
peter-sanderson
requested review from
szymonlesisz,
marekrjpolak,
mroz22 and
martykan
as code owners
peter-sanderson
commented
Dec 18, 2024
| // this error is dispatched by trezord when udev rules are missing | ||
| if (isLinux() && device?.error === 'LIBUSB_ERROR_ACCESS') { | ||
| return <> {isDesktop() ? <UdevDesktop /> : <UdevWeb />}</>; | ||
| items.push(TROUBLESHOOTING_TIP_UDEV); |
There was a problem hiding this comment.
Instead of download flow, we just shot tip to install udev rules. Its same tip as on Web where user selects from deb vs. rpm.
peter-sanderson
commented
Dec 18, 2024
peter-sanderson
force-pushed
the
udev-rules
branch
from
efe34a9 to
6c1d2b7
Compare
peter-sanderson
commented
Dec 18, 2024
peter-sanderson
commented
Dec 18, 2024
mroz22
reviewed
Dec 27, 2024
packages/suite/src/components/suite/PrerequisitesGuide/DeviceUnreadable.tsx
Show resolved
Hide resolved
peter-sanderson
commented
Jan 2, 2025
packages/suite/src/components/suite/PrerequisitesGuide/DeviceUnreadable.tsx
Show resolved
Hide resolved
peter-sanderson
commented
Jan 2, 2025
packages/suite/src/components/suite/PrerequisitesGuide/DeviceUnreadable.tsx
Show resolved
Hide resolved
peter-sanderson
commented
Jan 2, 2025
packages/suite/src/components/suite/PrerequisitesGuide/DeviceUnreadable.tsx
Show resolved
Hide resolved
peter-sanderson
commented
Jan 2, 2025
packages/suite/src/components/suite/PrerequisitesGuide/DeviceUnreadable.tsx
Show resolved
Hide resolved
peter-sanderson
commented
Jan 2, 2025
packages/suite/src/components/suite/PrerequisitesGuide/DeviceUnreadable.tsx
Show resolved
Hide resolved
peter-sanderson
commented
Jan 2, 2025
packages/suite/src/components/suite/PrerequisitesGuide/DeviceUnreadable.tsx
Show resolved
Hide resolved
peter-sanderson
force-pushed
the
udev-rules
branch
from
6c1d2b7 to
51f6874
Compare
peter-sanderson
force-pushed
the
udev-rules
branch
from
51f6874 to
4b0a68a
Compare
peter-sanderson
force-pushed
the
udev-rules
branch
2 times, most recently
from
3059985 to
db7512a
Compare
…al work on desktop
peter-sanderson
force-pushed
the
udev-rules
branch
from
db7512a to
9386967
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packaging formats are moving towards sand-boxing, we no longer can do a root-code-execution.
Also udev rules are now in the systemd (systemd/systemd#33813) we can expect that it will bubble up through releases of the distribution over few years.
Resolves: #15074