Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite-native): enhance layout of the account import summary screen #15170

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

yanascz
Copy link
Contributor

@yanascz yanascz commented Nov 1, 2024

The Confirm button fixed to the bottom of the screen.

Related Issue

Resolve #14065

Screenshots:

@yanascz yanascz added the mobile Suite Lite issues and PRs label Nov 1, 2024
@yanascz yanascz requested a review from a team as a code owner November 1, 2024 11:32
Copy link

github-actions bot commented Nov 1, 2024

Fingerprint is changed, new EAS Build(s) are now in pipeline.

Build with commit f8c1284

Name Build Details
🤖 Android build View build page
DetailsDistribution: INTERNAL
Build profile: preview
SDK version: 51.0.0
App version: 24.10.2
🍎 iOS build View build page
DetailsDistribution: INTERNAL
Build profile: preview
SDK version: 51.0.0
App version: 24.10.2
Fingerprint diff
[
  {
    "op": "changed",
    "source": {
      "type": "contents",
      "id": "expoConfig",
      "contents": "{\"android\":{\"adaptiveIcon\":{\"backgroundColor\":\"#E59D17\",\"foregroundImage\":\"./assets/appIcon_android.png\",\"monochromeImage\":\"./assets/appIcon_android.png\"},\"intentFilters\":[{\"action\":\"VIEW\",\"autoVerify\":true,\"category\":[\"BROWSABLE\",\"DEFAULT\"],\"data\":[{\"host\":\"dev.suite.sldev.cz\",\"pathPattern\":\"/connect/.*/.*/deeplink/.*\",\"scheme\":\"https\"},{\"host\":\"dev.suite.sldev.cz\",\"pathPattern\":\"/connect/.*/deeplink/.*\",\"scheme\":\"https\"}]}],\"package\":\"io.trezor.suite.preview\",\"permissions\":[\"android.permission.CAMERA\"]},\"extra\":{\"commitHash\":\"e197c9c0e022e924b1c333ae8a90d051d2a57173\",\"eas\":{\"projectId\":\"15998f8a-e75c-4b60-959d-6f68e5ff4936\"}},\"ios\":{\"associatedDomains\":[\"applinks:dev.suite.sldev.cz\"],\"bundleIdentifier\":\"io.trezor.suite.preview\",\"icon\":\"./assets/preview/appIcon.png\",\"infoPlist\":{\"ITSAppUsesNonExemptEncryption\":false,\"NSAppTransportSecurity\":{\"NSAllowsArbitraryLoads\":true,\"NSExceptionDomains\":{\"data.trezor.io\":{\"NSExceptionAllowsInsecureHTTPLoads\":true,\"NSIncludesSubdomains\":true},\"localhost\":{\"NSExceptionAllowsInsecureHTTPLoads\":true}}},\"NSCameraUsageDescription\":\"$(PRODUCT_NAME) needs access to your Camera to scan your XPUB.\",\"NSFaceIDUsageDescription\":\"$(PRODUCT_NAME) needs Face ID and Touch ID to keep sensitive data about your portfolio private.\",\"NSMicrophoneUsageDescription\":\"This app does not require access to the microphone.\",\"UIRequiredDeviceCapabilities\":[\"armv7\"]},\"supportsTablet\":true},\"name\":\"Trezor Suite Lite Preview\",\"orientation\":\"portrait\",\"owner\":\"trezorcompany-develop\",\"platforms\":[\"android\",\"ios\"],\"plugins\":[\"./plugins/withGradleProperties.js\",\"./plugins/withRemoveXcodeLocalEnv.js\",\"./plugins/withRemoveiOSNotificationEntitlement.js\",\"@trezor/react-native-usb/plugins/withUSBDevice.js\",[\"./plugins/withAndroidMainActivityAttributes.js\",{\"android:allowBackup\":false}],[\"@config-plugins/detox\",{\"subdomains\":\"*\"}],[\"@sentry/react-native/expo\",{\"organization\":\"satoshilabs\",\"project\":\"suite-native\",\"url\":\"https://sentry.io/\"}],[\"expo-build-properties\",{\"android\":{\"minSdkVersion\":28},\"ios\":{\"deploymentTarget\":\"14.0\"}}],[\"expo-camera\",{\"cameraPermission\":\"Allow $(PRODUCT_NAME) to access camera for QR code scanning.\",\"microphonePermission\":false,\"recordAudioAndroid\":false}],[\"expo-font\",{\"fonts\":[\"../../packages/theme/fonts/TTSatoshi-DemiBold.otf\",\"../../packages/theme/fonts/TTSatoshi-Medium.otf\",\"../../suite-common/icons/iconFontsMobile/TrezorSuiteIcons.ttf\"]}],[\"expo-image-picker\",{\"microphonePermission\":false,\"photosPermission\":\"Allow $(PRODUCT_NAME) to access your photos to let you import QR code images.\"}]],\"runtimeVersion\":\"9\",\"scheme\":\"trezorsuitelite\",\"sdkVersion\":\"51.0.0\",\"slug\":\"trezor-suite-preview\",\"splash\":{\"backgroundColor\":\"#25292E\",\"image\":\"./assets/splash_icon.png\",\"resizeMode\":\"contain\"},\"updates\":{\"requestHeaders\":{\"expo-channel-name\":\"preview\"},\"url\":\"https://u.expo.dev/15998f8a-e75c-4b60-959d-6f68e5ff4936\"},\"userInterfaceStyle\":\"automatic\",\"version\":\"24.10.2\"}",
      "reasons": [
        "expoConfig"
      ],
      "hash": "357a1ca4abd16138441a3f038cfe3e16259f3594"
    }
  }
]

Learn more about 𝝠 Expo Github Action

Copy link

github-actions bot commented Nov 1, 2024

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 9
  • More info

Learn more about 𝝠 Expo Github Action

@PeKne
Copy link
Contributor

PeKne commented Nov 1, 2024

I tested it on the iPhone 13 mini, and it works nicely!

One thing I don't like is that if you start filling in the account label input, the submit button is hidden behind the keyboard :/. Sometimes, even the input is hidden behind it. Can we change that?

ScreenRecording_11-01-2024.12-41-51_1.MP4

But it was probably like that, even with the old version, right? So maybe let's just create an issue and fix it separately.

@yanascz yanascz force-pushed the fix/native/account-import-summary branch 2 times, most recently from ef406d0 to 48f00f2 Compare November 1, 2024 14:13
@yanascz
Copy link
Contributor Author

yanascz commented Nov 1, 2024

One thing I don't like is that if you start filling in the account label input, the submit button is hidden behind the keyboard :/. Sometimes, even the input is hidden behind it. Can we change that?

I used KeyboardAvoidingView for the summary footer as in XpubHint. It's not ideal but at least it works the same.

@yanascz yanascz force-pushed the fix/native/account-import-summary branch from 48f00f2 to f8c1284 Compare November 1, 2024 14:43
@PeKne
Copy link
Contributor

PeKne commented Nov 4, 2024

Tested on both platforms 👍

@yanascz yanascz merged commit 87a6f5e into develop Nov 4, 2024
15 checks passed
@yanascz yanascz deleted the fix/native/account-import-summary branch November 4, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the button "Confirm" in syncing coins sticky to the bottom of the screen
2 participants