Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): check existing EAS builds before creating a new one #15172

Merged
merged 1 commit into from
Nov 4, 2024
Merged

chore(ci): check existing EAS builds before creating a new one #15172

merged 1 commit into from
Nov 4, 2024

Conversation

matejkriz
Copy link
Member

Description

  • runtimeVersion should ensure the compatibility, we should not create a new builds with the same runtimeVersion.
  • Listing two latest successful builds is fragile, it can list i.e. two android builds if ios had some issue, but should be good enough for now.

Related Issue

Resolve #14467

@matejkriz matejkriz requested a review from a team November 1, 2024 16:22
@matejkriz matejkriz added ci Continuous Integration (CI) related mobile Suite Lite issues and PRs build-mobile Trigger manual Suite Lite Preview build on PR labels Nov 1, 2024
@matejkriz
Copy link
Member Author

I just realized that build-mobile label is not working as expected, because it is still limited to PRs touching whitelisted paths (the path condition also applies for the labeled event) 🤦

@matejkriz matejkriz added build-mobile Trigger manual Suite Lite Preview build on PR and removed build-mobile Trigger manual Suite Lite Preview build on PR labels Nov 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2024 •
edited
Loading

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 9
  • More info

Learn more about 𝝠 Expo Github Action

@matejkriz
Copy link
Member Author

/rebase

@matejkriz matejkriz marked this pull request as ready for review November 4, 2024 09:44
@matejkriz matejkriz requested a review from vdovhanych as a code owner November 4, 2024 09:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/11661710915

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Rebasing failed, please rebase manually.

@matejkriz
chore(ci): check existing EAS builds before creating a new one
46ccdc2 
- runtimeVersion should ensure the compatibility, we should not create a new builds with the same runtimeVersion.
- Listing two latest successful builds is fragile, it can list i.e. two android builds if ios had some issue, but should be good enough for now.
@matejkriz matejkriz force-pushed the chore/native/preview-build-only-if-needed branch from de2806d to 46ccdc2 Compare November 4, 2024 14:28
@matejkriz matejkriz merged commit 05d128a into develop Nov 4, 2024
23 checks passed
@matejkriz matejkriz deleted the chore/native/preview-build-only-if-needed branch November 4, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nodonisko Nodonisko Nodonisko approved these changes

@vdovhanych vdovhanych Awaiting requested review from vdovhanych vdovhanych is a code owner

Assignees
No one assigned
Labels
build-mobile Trigger manual Suite Lite Preview build on PR ci Continuous Integration (CI) related mobile Suite Lite issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build app from PR
2 participants
@matejkriz @Nodonisko