chore: add no-unsafe-optional-chaining as it became part of recommanded settings #15202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-sanderson
requested review from
mroz22,
jvaclavik and
adamhavel
as code owners
peter-sanderson
commented
Nov 4, 2024
| @@ -124,7 +124,7 @@ export const Dropdown = forwardRef( | |||
| return; | |||
| } | |||
|
|
|||
| const { width, height } = menuRef.current?.getBoundingClientRect(); | |||
There was a problem hiding this comment.
Its checked above, !menuRef.current => early return, the ? not needed
peter-sanderson
commented
Nov 4, 2024
| const { inlineSize: elementWidth, blockSize: elementHeight } = | ||
| entries[0].borderBoxSize?.[0]; | ||
| const borderBoxSize = entries[0].borderBoxSize?.[0]; | ||
| if (!borderBoxSize) { |
There was a problem hiding this comment.
This probably never happens, but I wasn't sure
There was a problem hiding this comment.
Can't tell from documentation :/ But in any case, it's not worse than previous code, which throws error if !borderBoxSize
23 tasks
peter-sanderson
force-pushed
the
no-unsafe-optional-chaining
branch
from
6932fdd to
6f7e37c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eslint.org/docs/latest/rules/no-unsafe-optional-chaining became part of recommended settings
Prep, for #15144