Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/implement solana staking #15409

Closed
wants to merge 15 commits into from
Closed

Feat/implement solana staking #15409

wants to merge 15 commits into from

Conversation

dev-pvl
Copy link
Contributor

@dev-pvl dev-pvl commented Nov 15, 2024 •
edited
Loading

Description

  • implemented the initial Solana dashboard
  • renamed stake.ts to ethereumStaking.ts for clarity
  • implemented Solana staking
  • added Solana staking account balance
  • hide the staking buttons if debug mode is disabled
  • added @solana/web3.js-version1 for compatibility
  • upgraded @everstake/wallet-sdk to the latest
  • minor renaming and refactoring

Related Issue

Screenshots:

image
image
image

@dev-pvl dev-pvl force-pushed the feat/implement-solana-staking branch 2 times, most recently from 47ceb8d to e7afb45 Compare November 15, 2024 14:25
@tomasklim tomasklim self-assigned this Nov 15, 2024
vytick
vytick reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@vytick vytick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@dev-pvl dev-pvl force-pushed the feat/implement-solana-staking branch 2 times, most recently from a2b162e to 21e5cd1 Compare November 19, 2024 10:58
tomasklim
tomasklim requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@tomasklim tomasklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dev-pvl, we were discussing internally the use of @everstake/sdk and for Solana, we would like you to copy/paste content of https://github.com/everstake/wallet-sdk/blob/main/solana.js into our repo, probably some of the methods are already available in our repo, so just part of it. Thank you

@tomasklim tomasklim assigned tomasklim and dev-pvl and unassigned tomasklim Nov 22, 2024
@tomasklim tomasklim mentioned this pull request Nov 24, 2024
Closed
@dev-pvl
Copy link
Contributor Author

dev-pvl commented Nov 29, 2024 •
edited
Loading

JFYI, I upgraded everstake/wallet-sdk to the latest and added needed changes to the Ethereum staking.

@tomasklim tomasklim self-requested a review December 3, 2024 18:03
@vytick vytick added the solana label Dec 3, 2024
martykan
martykan reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@martykan martykan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will priority fees be supported? Not sure if the TXs will go through without them.
In our recent optimizations we updated TrezorConnect.blockchainEstimateFee so it can simulate the needed compute budget. Fee per unit is currently set at 0.3 lamports.

packages/blockchain-link-types/src/common.ts Outdated Show resolved Hide resolved
packages/blockchain-link/src/workers/utils.ts Outdated Show resolved Hide resolved
@dev-pvl dev-pvl force-pushed the feat/implement-solana-staking branch from a5ef7ca to 0784ae2 Compare December 4, 2024 12:02
dev-pvl added 12 commits December 4, 2024 14:08
@dev-pvl dev-pvl force-pushed the feat/implement-solana-staking branch from 0784ae2 to 807d05f Compare December 4, 2024 12:50
@dev-pvl dev-pvl marked this pull request as ready for review December 9, 2024 13:21
@dev-pvl dev-pvl requested review from MiroslavProchazka, a team and mroz22 as code owners December 9, 2024 13:21
@martykan martykan mentioned this pull request Dec 16, 2024
Merged
@martykan
Copy link
Member

Merged from our branch in #15988

@martykan martykan closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vytick vytick vytick left review comments

@martykan martykan martykan left review comments

@jirih-stsh jirih-stsh jirih-stsh left review comments

@marekrjpolak marekrjpolak Awaiting requested review from marekrjpolak marekrjpolak is a code owner

@tomasklim tomasklim Awaiting requested review from tomasklim

@MiroslavProchazka MiroslavProchazka Awaiting requested review from MiroslavProchazka MiroslavProchazka is a code owner

@mroz22 mroz22 Awaiting requested review from mroz22 mroz22 is a code owner

Assignees

@dev-pvl dev-pvl

Labels
solana
Projects
Suite Desktop
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dev-pvl @martykan @vytick @tomasklim @jirih-stsh