Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(connect): new option to order pubkeys LEXICOGRAPHIC for multisig #15865

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

test(connect): new option to order pubkeys LEXICOGRAPHIC for multisig #15865

wants to merge 2 commits into from

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Dec 10, 2024 •
edited
Loading

@trezor/connect implementation of trezor/trezor-firmware#4351

@mroz22 mroz22 mentioned this pull request Dec 10, 2024
Draft
@mroz22 mroz22 requested a review from karliatto December 17, 2024 08:38
@mroz22
Copy link
Contributor Author

mroz22 commented Dec 17, 2024

@karliatto please finish this 🙏 it would make sense to add also some of the tests fixtures from the aforementioned PR to the firmware repo

@mroz22 mroz22 removed the request for review from karliatto December 17, 2024 09:41
@karliatto karliatto force-pushed the pubkeys-order branch 5 times, most recently from a91d57e to 293dbcf Compare January 13, 2025 08:02
@karliatto
Copy link
Member

Definitions were already merged to develop by this 3737c9e

So with this PR we are now only adding tests.

@karliatto karliatto force-pushed the pubkeys-order branch 4 times, most recently from 4ca9d26 to 685a687 Compare January 13, 2025 13:41
@karliatto karliatto changed the title feat(protobuf): add pubkeys order fields test(connect): new option to order pubkeys LEXICOGRAPHIC for multisig Jan 13, 2025
@karliatto
Copy link
Member

Tests introduced here were tested and passing also with "2-main" https://github.com/trezor/trezor-suite/actions/runs/12748488684/job/35528852652?pr=15865

@karliatto karliatto marked this pull request as ready for review January 13, 2025 15:02
mroz22
mroz22 commented Jan 14, 2025
View reviewed changes
packages/connect/e2e/__fixtures__/getAddressMultisigPubkeysOrder.ts
pubkeys: pubkeysOrder2,
signatures: ['', ''],
m: 2,
pubkeys_order: MultisigPubkeysOrder.PRESERVED,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I understand that pubkeys_order doesn't need to be added anywhere in the runtime, because it s part of multisig field which is already passed to the device.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.

mroz22
mroz22 commented Jan 14, 2025
View reviewed changes
packages/connect/e2e/__fixtures__/getAddressMultisigPubkeysOrder.ts Outdated
@@ -0,0 +1,119 @@
import { MultisigPubkeysOrder } from '@trezor/protobuf/src/messages';

// https://github.com/trezor/trezor-firmware/blob/45a029edcc720b0825e4a13504d460faada8b72c/tests/device_tests/bitcoin/test_getaddress.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nitpick. you probably wanted to list this URL? https://github.com/trezor/trezor-firmware/blob/main/tests/device_tests/bitcoin/test_getaddress.py

using https://github.com/trezor/trezor-firmware/blob/45a029edcc720b0825e4a13504d460faada8b72c/tests/device_tests/bitcoin/test_getaddress.py I don't see addressUnsorted1 and addressUnsorted2 in there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 0dfdc4d

@mroz22
Copy link
Contributor Author

mroz22 commented Jan 15, 2025

@karliatto since I created the PR, its up to you to merge. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karliatto karliatto karliatto left review comments

@szymonlesisz szymonlesisz Awaiting requested review from szymonlesisz szymonlesisz is a code owner

@martykan martykan Awaiting requested review from martykan martykan is a code owner

@marekrjpolak marekrjpolak Awaiting requested review from marekrjpolak marekrjpolak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@karliatto karliatto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroz22 @karliatto