Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite): new device renders and animations #15966

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

MiroslavProchazka
Copy link
Contributor

@MiroslavProchazka MiroslavProchazka commented Dec 14, 2024

Content of this PR:

  • Adjusting static renders and device rotations to enhance visibility in dark mode and improve differentiation between models.

  • Adjusting image size in ViewOnly Promo, instead of trezor-"modelname".png use trezor-"modelname"-large.png

  • I've used "ffmpeg -c:v libvpx-vp9 -i TS5_rotation_purplegrey_v3_1400x2440.webm -vf "scale=172:300" -aspect 172:300 TS5_rotation_purple_1.webm" to prepare the animations

T1B1 before
image
T1B1 after
image

@@ -32,9 +32,14 @@ export const RotateDeviceImage = ({

const isDeviceImageRotating =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All devices are rotating so no need for this condition anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@MiroslavProchazka MiroslavProchazka force-pushed the test/new-device-images branch 4 times, most recently from 6515ca7 to dcb68ae Compare December 17, 2024 12:57
@MiroslavProchazka MiroslavProchazka force-pushed the test/new-device-images branch 3 times, most recently from ff724ac to ab0648d Compare January 14, 2025 11:34
@MiroslavProchazka MiroslavProchazka self-assigned this Jan 14, 2025
@MiroslavProchazka MiroslavProchazka changed the title test(suite): test new device renders feat(suite): new device renders and animations Jan 17, 2025
@MiroslavProchazka MiroslavProchazka marked this pull request as ready for review January 22, 2025 15:15
Copy link
Contributor

@jvaclavik jvaclavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvaclavik jvaclavik merged commit 7704090 into develop Jan 22, 2025
33 checks passed
@jvaclavik jvaclavik deleted the test/new-device-images branch January 22, 2025 15:23
@bosomt
Copy link
Contributor

bosomt commented Jan 23, 2025

QA OK

Info:

  • Suite version: web 25.2.0 (769cb04)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T3T1 2.8.7 regular (revision 8a254aa8eae82f99630df63f40e4d290066a3efc)
  • Transport: WebUsbTransport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

4 participants