Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2e): Upgrade Playwright version to 1.49.1 #16173

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Vere-Grey
Copy link
Contributor

@Vere-Grey Vere-Grey commented Jan 5, 2025

Upgrades to lastest version 1.49.1 of Playwright to utilize latest features

I had to upgrade playwright in all 3 workspaces due dependencies between them

All tests in all workspaces passed. I have not discussed the upgrade with anyone so I will not merge until I get all 3 approves. Also, please feel free to challenge the upgrade in any way. :) 👍

@Vere-Grey Vere-Grey requested a review from HajekOndrej January 5, 2025 13:48
@Vere-Grey Vere-Grey self-assigned this Jan 5, 2025
Copy link

github-actions bot commented Jan 5, 2025

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 21
  • More info

Learn more about 𝝠 Expo Github Action

@Vere-Grey Vere-Grey marked this pull request as ready for review January 6, 2025 07:55
@martykan
Copy link
Member

martykan commented Jan 6, 2025

What is the main change for us? The new headless mode?

@Vere-Grey
Copy link
Contributor Author

What is the main change for us? The new headless mode?

I was mainly after Aria snapshots, latest browsers and as you mentioned, the new headless (New Headless on the other hand is the real Chrome browser, and is thus more authentic, reliable, and offers more features. This makes it more suitable for high-accuracy end-to-end web app testing or browser extension testing.)

Copy link
Member

@martykan martykan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I don't see any downsides

@HajekOndrej HajekOndrej merged commit 102be08 into develop Jan 6, 2025
77 checks passed
@HajekOndrej HajekOndrej deleted the feat/playwright-version-upgrade branch January 6, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants