Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(suite-native): add evm L2s under feature flag #16212

Merged
merged 1 commit into from
Jan 8, 2025
Merged

feat(suite-native): add evm L2s under feature flag #16212

merged 1 commit into from
Jan 8, 2025

Conversation

vytick
Copy link
Contributor

@vytick vytick commented Jan 6, 2025

Related Issue

Resolve #16185

Screenshots:

@vytick vytick added mobile Suite Lite issues and PRs EVM Issues related to networks based on Ethereum Virtual Machine labels Jan 6, 2025
@vytick vytick requested a review from a team as a code owner January 6, 2025 21:16
@vytick vytick requested a review from PeKne January 7, 2025 22:05
PeKne
PeKne approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@PeKne PeKne left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the first letters of FF name to capital for consistency. Otherwise LGTM 👍.

suite-native/feature-flags/src/featureFlagsSlice.ts Outdated Show resolved Hide resolved
suite-native/feature-flags/src/featureFlagsSlice.ts Outdated Show resolved Hide resolved
suite-native/module-dev-utils/src/components/FeatureFlags.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 21
  • More info

Learn more about 𝝠 Expo Github Action

@vytick
Copy link
Contributor Author

vytick commented Jan 8, 2025

/rebase

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12670561167

@trezor-ci trezor-ci force-pushed the feat/native/evms-with-featureflag branch from 84e0230 to 0e139ae Compare January 8, 2025 12:29
@vytick vytick merged commit 126fd7e into develop Jan 8, 2025
16 checks passed
@vytick vytick deleted the feat/native/evms-with-featureflag branch January 8, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeKne PeKne PeKne approved these changes

Assignees
No one assigned
Labels
EVM Issues related to networks based on Ethereum Virtual Machine mobile Suite Lite issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add eth L2s under feature flag
2 participants
@vytick @PeKne