fix: filter all requests not just xhr, all requests are potentially harmfull (can spy on the user via header, etc...) #16259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we got somehow code injection like this, it will get through as the
request-filter.ts
only check forxhr
requests.Asset loading can be potentially harmful as well. It can be utilized for
ALL requests suite does shall be subject to the whitelisting to reduce the attack vector.
For QA
Related to: #7171