feat(mobile): make feature flags more dummy proof #16269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think the hooks are worth it? Wouldn't it be easier to just use a selector or dispatch toggle action everywhere? |
|
Rebase to make e2e tests passing again: #16276 |
matejkriz
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
After the internal discussion, I'm ok with keeping it wrapped in simple hooks 👌
|
/rebase |
trezor-ci
force-pushed
the
feat/change-feature-flag-api
branch
from
f7cfe41 to
fc49b33
Compare
|
🚀 Expo preview is ready!
|
|
QA OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make feature flag more dummy proof so it is not possible to have
always truthycondition then. We only need to read FF value anyway and write it only in single place.QA: Please test that all FF works correctly 😄
Related Issue
Resolve
Screenshots: