fix(suite-native): use correct receive flow screens for connected device #16312
Conversation
yanascz
commented
Jan 10, 2025
yanascz
commented
- Incorrectly removed screens returned back
- Flow unified for Portfolio tracker and connected device
- Receive screens refactored to prevent UI & scrolling glitches
|
🚀 Expo preview is ready!
|
yanascz
force-pushed
the
fix/native/dashboard-receive-flow
branch
4 times, most recently
from
458f254 to
f413cab
Compare
yanascz
force-pushed
the
fix/native/dashboard-receive-flow
branch
from
f413cab to
dbc7fde
Compare
suite-native/module-receive/src/screens/ReceiveAccountsScreen.tsx
Outdated
Show resolved
Hide resolved
| <IconButton | ||
| iconName="plus" | ||
| onPress={ | ||
| isSelectedDevicePortfolioTracker ? navigateToImportScreen : navigateToAddCoinAccount | ||
| } | ||
| colorScheme="tertiaryElevation0" | ||
| size="medium" | ||
| isLoading={hasDeviceDiscovery} |
There was a problem hiding this comment.
When discovery is running (and the icon is loading), tapping that button starts Add new coin flow. Is that intended?
There was a problem hiding this comment.
Great catch, that's a bug. Will fix in a fixup.
There was a problem hiding this comment.
From testing I see only one issue at the very end of the receive flow -
When I complete the entire receive flow confirm the receive address on the Trezor (or skip the confirmation in the Portfolio tracker), the only way back is the Back icon, but that only takes me back one screen to the Receive flow - selecting another account.
As a user, I would expect to return to the Dashboard so I don't have to click twice. Ideally the icon can be changed to X in that case.
What do you think?
yanascz
force-pushed
the
fix/native/dashboard-receive-flow
branch
from
12226d5 to
bf65d9a
Compare
Let's solve in a follow-up since it requires bigger refactoring of the navigation. |
