Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16190 we show network symbol in place of display symbol #16325

Merged
merged 2 commits into from
Jan 13, 2025
Merged

16190 we show network symbol in place of display symbol #16325

merged 2 commits into from
Jan 13, 2025

Conversation

jbazant
Copy link
Contributor

@jbazant jbazant commented Jan 13, 2025 •
edited by vytick
Loading

Description

  • Uses displaySymbol instead of symbol in prepareNetworkSymbolFormatter.
  • Bonus: Fixed translations in CoinPriceCard.

Related Issue

Resolves #16190
Screenshot 2025-01-13 at 13 10 28
Screenshot 2025-01-13 at 13 11 49

Screenshots:

@jbazant jbazant requested a review from vytick January 13, 2025 12:13
@jbazant jbazant requested a review from a team as a code owner January 13, 2025 12:13
@jbazant jbazant added the mobile Suite Lite issues and PRs label Jan 13, 2025
@jbazant jbazant force-pushed the 16190-We-show-network-symbol-in-place-of-displaySymbol branch from 97ddad4 to 44993f3 Compare January 13, 2025 16:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 21
  • More info

Learn more about 𝝠 Expo Github Action

vytick
vytick approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@vytick vytick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍 . Thanks for the test 🙇

suite-common/formatters/src/formatters/tests/prepareNetworkSymbolFormatter.test.ts

import { prepareNetworkSymbolFormatter } from '../prepareNetworkSymbolFormatter';

describe('prepareNetworkSymbolFormatter', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@vytick vytick force-pushed the 16190-We-show-network-symbol-in-place-of-displaySymbol branch from ea3a752 to 02a57ed Compare January 13, 2025 21:14
@vytick vytick merged commit 73c2cd0 into develop Jan 13, 2025
35 checks passed
@vytick vytick deleted the 16190-We-show-network-symbol-in-place-of-displaySymbol branch January 13, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vytick vytick vytick approved these changes

Assignees
No one assigned
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We show network symbol in place of displaySymbol
2 participants
@jbazant @vytick