fix(suite-desktop-core): app isHidden check is mac only #16326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martykan
added
the
build-desktop
martykan
force-pushed
the
fix/electron-app-ishidden-mac-only
branch
from
0ae396c to
2bd5cb5
Compare
mroz22
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed this error message in Electron logs in CI tests. We were checking
app.isHiddenon window close, this function only works on Mac and it would only be used in logic for Mac, however it was called on all platforms.I believe this wasn't causing other issues besides the error message itself.
Also removes a check for
bridge-testflag which changes the behavior of autostart, this is not relevant anymore and messes with tests.