-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(e2e): Convert to PW doge-send #16335
feat(e2e): Convert to PW doge-send #16335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The values that are scrolled out of view are tested separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copypasted from cy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copypasted from cy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor refactoring of imports and naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also moved to mocks folder
@@ -125,6 +129,10 @@ export class MarketActions { | |||
'@coinmarket/offer/continue-transaction-button', | |||
); | |||
this.exchangeFeeDetails = this.page.getByTestId('@wallet/fee-details'); | |||
this.broadcastButton = this.page.getByTestId('broadcast-button'); | |||
this.sendAddressInput = this.page.getByTestId('outputs.0.address'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to refactor those to our standard way of data-testid but it is bit bigger so I would leave it for the big refactoring
e1bb94a
to
3ece88c
Compare
minor refactoring of mock naming new locators
3ece88c
to
e984b00
Compare
await settingsPage.coins.enableNetwork('doge'); | ||
await settingsPage.coins.openNetworkAdvanceSettings('doge'); | ||
await settingsPage.coins.changeBackend('blockbook', blockbookMock.url); | ||
await settingsPage.coins.activateCoinsButton.click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was instability in test that was happening quite often. Test would disable BTC and enable Doge coin. then navigate to dashboard and expecting a discovery to happen. But that would not happen in like 50 percent of cases. Solution is to trigger the discovery via Activate Coins button.
I was not able to duplicate this issue manually. And I will ask around if this happend to anyone.
But if not -> then we should probably do discovery mainly this way for sake of stability.
minor refactoring of mock naming
new locators
Description
Converts to PW test suite wallet - doge-send
Related Issue
Resolve 15606
Screenshots: