-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test IDs and tests for passphrase flow #12176 #16427
Conversation
🚀 Expo preview is ready!
|
9ef5de9
to
0b3e696
Compare
suite-native/module-onboarding-legacy/src/components/E2ESkipOnboardingButton.tsx
Outdated
Show resolved
Hide resolved
66e6944
to
a5054eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the tests! 🚀 Great to see that this technical debt is lowering.
3a265ca
to
6f869b8
Compare
6f869b8
to
98b1dd2
Compare
Please use fixup commits for fixing PR comments next time. It is way easier for reviewers like that 🙏. Here is Trezor Code Review Guide where is everything described (you need to open the attached firmware docs link to see all the details) Apart from that, LGTM 🚀. I will approve it when @yanascz will resolve his comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Description
Related Issue
Resolve #12176
Screenshots: