Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test IDs and tests for passphrase flow #12176 #16427

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

jbazant
Copy link
Contributor

@jbazant jbazant commented Jan 16, 2025

Description

Related Issue

Resolve #12176

Screenshots:

@jbazant jbazant added the mobile Suite Lite issues and PRs label Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 23
  • More info

Learn more about 𝝠 Expo Github Action

@jbazant jbazant force-pushed the 12176-Add-tests-for-passphrase-flow- branch 8 times, most recently from 9ef5de9 to 0b3e696 Compare January 21, 2025 11:01
@jbazant jbazant changed the title WIP: Add test IDs and tests for passphrase flow #12176 Add test IDs and tests for passphrase flow #12176 Jan 21, 2025
@jbazant jbazant marked this pull request as ready for review January 21, 2025 11:02
@jbazant jbazant requested review from a team and vdovhanych as code owners January 21, 2025 11:02
@jbazant jbazant force-pushed the 12176-Add-tests-for-passphrase-flow- branch from 66e6944 to a5054eb Compare January 21, 2025 16:19
Copy link
Contributor

@PeKne PeKne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the tests! 🚀 Great to see that this technical debt is lowering.

@jbazant jbazant force-pushed the 12176-Add-tests-for-passphrase-flow- branch 2 times, most recently from 3a265ca to 6f869b8 Compare January 22, 2025 13:11
@jbazant jbazant requested a review from Nodonisko as a code owner January 22, 2025 13:11
@jbazant jbazant force-pushed the 12176-Add-tests-for-passphrase-flow- branch from 6f869b8 to 98b1dd2 Compare January 23, 2025 06:28
@PeKne
Copy link
Contributor

PeKne commented Jan 23, 2025

Please use fixup commits for fixing PR comments next time. It is way easier for reviewers like that 🙏. Here is Trezor Code Review Guide where is everything described (you need to open the attached firmware docs link to see all the details)

Apart from that, LGTM 🚀. I will approve it when @yanascz will resolve his comments.

Copy link
Contributor

@yanascz yanascz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@vytick vytick merged commit d459f26 into develop Jan 23, 2025
78 of 80 checks passed
@vytick vytick deleted the 12176-Add-tests-for-passphrase-flow- branch January 23, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test IDs and tests for passphrase flow
4 participants