Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(suite-native): hide balance if discovery is still loading so it's not final #16507

Merged
merged 1 commit into from
Jan 21, 2025
Merged

feat(suite-native): hide balance if discovery is still loading so it's not final #16507

merged 1 commit into from
Jan 21, 2025

Conversation

matejkriz
Copy link
Member

Description

  • Do not show global wallet balance above graph if it's not final, keep skeleton there until discovery is finished.
  • Keep the balance visible while switching graph time frame (graph is loading, but current total value remains the same)

Related Issue

Followup for #16457

@matejkriz matejkriz requested a review from a team as a code owner January 21, 2025 13:26
@matejkriz matejkriz added the mobile Suite Lite issues and PRs label Jan 21, 2025
yanascz
yanascz approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@yanascz yanascz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

@matejkriz matejkriz merged commit b6893f7 into develop Jan 21, 2025
18 of 20 checks passed
@matejkriz matejkriz deleted the feat/native/balance-during-discovery branch January 21, 2025 15:12
@STew790
Copy link
Contributor

STew790 commented Jan 22, 2025

QA OK
Works really great 💪

Info
25.1.3 33aa804

@STew790 STew790 added the QA OK Issue passed QA without any blocker label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanascz yanascz yanascz approved these changes

Assignees
No one assigned
Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Projects
Suite Mobile
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejkriz @STew790 @yanascz