Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build desktop main code with webpack #9931

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Build desktop main code with webpack #9931

merged 3 commits into from
Nov 17, 2023

Conversation

marekrjpolak
Copy link
Contributor

Description

In order to deduplicate bundled js code for electron main process, webpack is used for the whole thing (instead of using it only for connect while preserving esbuild for the rest, as it was after #9552).

@marekrjpolak marekrjpolak force-pushed the chore/connect-electron-webpack branch 2 times, most recently from b5f0c7a to 62dc6ce Compare November 14, 2023 08:55
@socket-security Socket Security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: [email protected]

mroz22
mroz22 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@mroz22 mroz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks better than it was before.

@marekrjpolak marekrjpolak marked this pull request as ready for review November 15, 2023 13:26
@marekrjpolak marekrjpolak force-pushed the chore/connect-electron-webpack branch from 62dc6ce to 5783738 Compare November 15, 2023 15:31
tomasklim
tomasklim approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@tomasklim tomasklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Mac. I also run desktop tests in CI and looks ok

packages/suite-desktop-core/webpack/core.webpack.config.ts Outdated Show resolved Hide resolved
@marekrjpolak marekrjpolak force-pushed the chore/connect-electron-webpack branch from 5783738 to b62f8d7 Compare November 16, 2023 10:07
@tomasklim tomasklim merged commit aa680c0 into develop Nov 17, 2023
31 checks passed
@tomasklim tomasklim deleted the chore/connect-electron-webpack branch November 17, 2023 12:30
@Lemonexe Lemonexe mentioned this pull request Nov 25, 2024
Draft
@Lemonexe Lemonexe mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nodonisko Nodonisko Nodonisko left review comments

@tomasklim tomasklim tomasklim approved these changes

@mroz22 mroz22 mroz22 approved these changes

@matejkriz matejkriz Awaiting requested review from matejkriz

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Suite Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marekrjpolak @Nodonisko @mroz22 @tomasklim