Add a testing only feature for running as unprivileged user #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
force-pushed
the
unprivileged_testing
branch
3 times, most recently
from
3ef0998 to
295e4dd
Compare
This feature must never be used in production. To ensure this, it needs to be enabled using RUSTFLAGS rather than as cargo feature, there is a compile error for using it with debug assertions enabled and we also check for setuid and being root at runtime and refuse to run in either case.
bjorn3
force-pushed
the
unprivileged_testing
branch
from
295e4dd to
5b38647
Compare
|
Having a tag for this commit, to be cherry-picked (and kept-up-to-date) seems very useful. I'm not convinced yet that it needs to be in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature must never be used in production. To ensure this, it needs to be enabled using RUSTFLAGS rather than as cargo feature, there is a compile error for using it with debug assertions enabled and we also check for setuid and being root at runtime and refuse to run in either case.
It would also be possible to keep this in a side branch from which you can cherry-pick when you want to do this kind of testing if the risk of someone using this in production is still considered too big despite the countermeasures against this.