Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #134
by just ignoring those tests. The error is not a real error in that we produce something different form zlib(-ng) on those platforms, but our output is still valid.
On CI, I can't get the cross-compilation of zlib-ng to work, but I did run this locally (where cross-compilation does work?!) . We now test the
zlib-rs
crate on i686 and s390x, so real logic errors should be caught by that. I'll give cross-compiling zlib-ng another go at a later point.