Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New onboarding question #1404
New onboarding question #1404
Changes from 17 commits
feede85
008a880
6a85d58
30d0178
7ce56fa
23ceefc
96578bb
575dffb
fb0397a
1cb90bb
daafd5e
c791e50
34c6e9a
ec45694
071954f
36bca68
7107119
3898541
deea7c9
43c39b1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one could have stayed as
requireUserId
. TherequireUser
call does a database call. It's not a big deal because this is such an infrequently viewed page though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with suggestion: Form updates for new feedback field
The changes to the form look good:
whyUseUs
field is correctly implemented.companySize
andwhyUseUs
inputs is appropriate.However, there's one improvement that can be made:
Add error handling for the
whyUseUs
field to be consistent with other form fields. Apply this change:Also, update the form hook to include
whyUseUs
:These changes will ensure that any validation errors for the
whyUseUs
field are properly displayed to the user, maintaining consistency with other form fields.📝 Committable suggestion