-
-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add known issue for realtime #1452
Conversation
|
WalkthroughThe documentation for the Trigger.dev Realtime API has been updated to include a new section on "Known issues." This section addresses a specific problem where the API does not function properly when subscribing to runs with large payloads or outputs stored in an object store. It specifies a workaround of keeping payloads and outputs under 128KB and includes a link to a relevant GitHub issue for further tracking. Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
docs/realtime/overview.mdx (1)
267-267
: Add comma for better readability.Add a comma after the introductory phrase for improved readability.
-As a workaround you'll need to keep payloads and outputs below 128KB when using the realtime API. +As a workaround, you'll need to keep payloads and outputs below 128KB when using the realtime API.🧰 Tools
🪛 LanguageTool
[typographical] ~267-~267: Consider adding a comma after this introductory phrase.
Context: ...gerdotdev/trigger.dev/issues/1451. As a workaround you'll need to keep payloads and output...(AS_A_NN_COMMA)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
docs/realtime/overview.mdx
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/realtime/overview.mdx
[typographical] ~267-~267: Consider adding a comma after this introductory phrase.
Context: ...gerdotdev/trigger.dev/issues/1451. As a workaround you'll need to keep payloads and output...
(AS_A_NN_COMMA)
🔇 Additional comments (1)
docs/realtime/overview.mdx (1)
264-267
: LGTM! Clear and informative known issues section.
The addition of the known issues section is valuable, providing users with:
- Clear description of the limitation
- Specific size threshold (128KB)
- Link to tracking issue
- Practical workaround
🧰 Tools
🪛 LanguageTool
[typographical] ~267-~267: Consider adding a comma after this introductory phrase.
Context: ...gerdotdev/trigger.dev/issues/1451. As a workaround you'll need to keep payloads and output...
(AS_A_NN_COMMA)
Summary by CodeRabbit