Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove octez node stuff and simplify octez-client stuff for developers #137

Merged
merged 7 commits into from
Nov 6, 2023

Conversation

timothymcmackin
Copy link
Collaborator

@timothymcmackin timothymcmackin commented Oct 31, 2023

Docs on most parts of octez belong in the octez docs, but Tezos app developers may need to use the octez client for things on the CLI.

Preview: https://docs-staging-git-octez-client-trili-tech.vercel.app/docs/developing/octez-client

Screenshot 2023-11-01 at 3 42 42 PM

@timothymcmackin timothymcmackin self-assigned this Oct 31, 2023
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 3:07pm

@@ -0,0 +1,73 @@
---
title: Sending transactions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is a bit tricky as it's called Sending transactions, but we have way more than that here, so maybe Blockchain interactions or Transaction interactions or just Transactions with Octez WDYT @timothymcmackin ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. I like "sending transactions" because it's a task instead of a concept and because it's simple and something that developers need to do to test contracts. Maybe "Interacting with contracts"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, "Interacting with contracts" sounds good

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to "Interacting with contracts"

Copy link
Collaborator

@NicNomadic NicNomadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the octez-client section, which LGTM modulo a couple of remarks.

docs/developing/octez-client/accounts.md Outdated Show resolved Hide resolved
docs/developing/octez-client/transactions.md Outdated Show resolved Hide resolved
timothymcmackin and others added 2 commits November 6, 2023 09:30
Co-authored-by: NicNomadic <[email protected]>
Copy link
Contributor

@beatalipska beatalipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@timothymcmackin timothymcmackin merged commit 3462d09 into staging Nov 6, 2023
@timothymcmackin timothymcmackin deleted the octez-client branch November 6, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants