Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic unwinding #380

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ members = [
"macros",
"method-override",
"native-tls",
"panic-boundary",
"proxy",
"redirect",
"router",
Expand Down
20 changes: 20 additions & 0 deletions panic-boundary/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
[package]
name = "trillium-panic-boundary"
version = "0.1.0"
authors = ["Jacob Rothstein <[email protected]>"]
edition = "2021"
description = "experimental panic boundary for trillium.rs"
license = "MIT OR Apache-2.0"
repository = "https://github.com/trillium-rs/trillium"
readme = "../README.md"
keywords = ["trillium", "framework", "async"]
categories = ["web-programming::http-server", "web-programming"]

[dependencies]
async-channel = "1.9.0"
futures-lite = "1.13.0"
trillium = { path = "../trillium", version = "^0.2.0"}
trillium-macros = { version = "0.0.4", path = "../macros" }

[dev-dependencies]
trillium-smol = { path = "../smol" }
12 changes: 12 additions & 0 deletions panic-boundary/examples/panic.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
use trillium::Conn;
use trillium_panic_boundary::Unwind;

fn main() {
trillium_smol::run(Unwind::new(|conn: Conn| async move {
if conn.path().starts_with("/panic") {
panic!("PANIC: {} {}", conn.method(), conn.path());
} else {
conn.ok("no panic")
}
}));
}
93 changes: 93 additions & 0 deletions panic-boundary/src/lib.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
use futures_lite::FutureExt;
use std::{
borrow::Cow,
panic::{resume_unwind, AssertUnwindSafe},
};
use trillium::{Body, Conn, Handler};
use trillium_macros::Handler;

pub struct DefaultPanicHandler;
#[trillium::async_trait]
impl Handler for DefaultPanicHandler {
async fn run(&self, mut conn: Conn) -> Conn {
let body = conn
.take_panic_message()
.map_or_else(|| "internal server error".into(), Body::from);
conn.with_status(500).with_body(body).halt()
}
}

#[derive(Handler, Debug)]
pub struct Unwind<H: Handler, PH: Handler> {
#[handler(except = run)]
handler: H,
panic_handler: PH,
}

struct PanicMessage(Cow<'static, str>);

impl<H> Unwind<H, DefaultPanicHandler>
where
H: Handler,
{
pub fn new(handler: H) -> Self {
Self {
handler,
panic_handler: DefaultPanicHandler,
}
}
}

impl<H, PH> Unwind<H, PH>
where
H: Handler,
PH: Handler,
{
pub fn with_panic_handler<PH2: Handler>(self, panic_handler: PH2) -> Unwind<H, PH2> {
Unwind {
handler: self.handler,
panic_handler,
}
}

pub async fn run(&self, mut conn: Conn) -> Conn {
let (tx, rx) = async_channel::bounded(1);
conn.on_drop(move |conn| {
let _ = tx.try_send(conn);
});

match AssertUnwindSafe(self.handler.run(conn))
.catch_unwind()
.await
{
Ok(conn) => conn,
Err(e) => match rx.recv().await {
Ok(mut conn) => {
if let Some(s) = e.downcast_ref::<&str>() {
conn.set_state(PanicMessage(Cow::from(*s)));
} else if let Some(s) = e.downcast_ref::<String>() {
conn.set_state(PanicMessage(Cow::from(s.clone())));
}

self.panic_handler.run(conn).await
}

Err(_) => resume_unwind(e),
},
}
}
}

pub trait UnwindConnExt {
fn panic_message(&self) -> Option<&str>;
fn take_panic_message(&mut self) -> Option<Cow<'static, str>>;
}
impl UnwindConnExt for Conn {
fn panic_message(&self) -> Option<&str> {
self.state().map(|PanicMessage(ref cow)| &**cow)
}

fn take_panic_message(&mut self) -> Option<Cow<'static, str>> {
self.take_state().map(|PanicMessage(cow)| cow)
}
}
Loading
Loading