Minimal support for downcasting to a custom transport type #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
- Coverage 48.03% 47.94% -0.09%
==========================================
Files 169 169
Lines 6581 6593 +12
==========================================
Hits 3161 3161
- Misses 3420 3432 +12 ☔ View full report in Codecov by Sentry. |
|
This looks great, thanks! |
… reference These functions are useful for getting access to an application-specific custom transport type that has additional methods.
These functions are useful for getting access to an application-specific custom transport type that has additional methods.
joshtriplett
force-pushed
the
downcast-transport-minimal
branch
from
b245bd3 to
2549594
Compare
|
@jbr CI is no longer failing. (Failure looked spurious, I rebased which also re-ran CI and it passes now.) |
|
Unfortunately the failure wasn't spurious, but it is fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to the approach in
#432 , based on the comment at
#432 (comment) .
I added methods on
trillium_http::Connto get a&Transportor&mut Transport.I then added methods on
BoxedTransportto downcast to a specific typeimplementing
Transport. I went with downcast methods onBoxedTransportrather than exposing
as_any()andas_mut_any()directly, because the latterwould have been the same amount of code and with a more complex interface.
With both of these changes, given a
trillium::Conn, you can callconn.inner().transport().downcast_ref()orconn.inner().transport_mut().downcast_mut()to get your custom transporttype.
I think this is the minimal amount of support needed to make this possible.