Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend/Backend/DB: Notification support for like, comment and quiz reminders #115

Merged
merged 2 commits into from
Oct 8, 2022
Merged

Frontend/Backend/DB: Notification support for like, comment and quiz reminders #115

merged 2 commits into from
Oct 8, 2022

Conversation

gao-ti
Copy link
Contributor

@gao-ti gao-ti commented Oct 8, 2022

Description

This PR includes

  • notifications of likes
  • notifications of comments
  • notifications of quiz reminders

Future work

  • Now quiz reminders appear regardless of when I last took it
  • Checked/Unchecked notifications cannot be distinguished
  • Do not redirect to the post where comments/likes are

@gao-ti gao-ti self-assigned this Oct 8, 2022
@gao-ti
Copy link
Contributor Author

gao-ti commented Oct 8, 2022

image

@gao-ti gao-ti mentioned this pull request Oct 8, 2022
Open
3 tasks
davidfortuoso-ti
davidfortuoso-ti approved these changes Oct 8, 2022
View reviewed changes
Copy link
Contributor

@davidfortuoso-ti davidfortuoso-ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, good job with the notifications

@davidfortuoso-ti
Copy link
Contributor

One suggestion: Close notification dropdown when user clicks outside of the notification box.

arsen-ti
arsen-ti approved these changes Oct 8, 2022
View reviewed changes
Copy link
Contributor

@arsen-ti arsen-ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@gao-ti gao-ti merged commit 4df43c2 into master Oct 8, 2022
@davidfortuoso-ti davidfortuoso-ti deleted the notification-back branch October 19, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfortuoso-ti davidfortuoso-ti davidfortuoso-ti approved these changes

@arsen-ti arsen-ti arsen-ti approved these changes

@kushal-ti kushal-ti Awaiting requested review from kushal-ti

Assignees

@gao-ti gao-ti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gao-ti @davidfortuoso-ti @arsen-ti