Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Ripple: Set primary/secondary color #322

Closed
4 tasks done
trimox opened this issue Oct 26, 2017 · 5 comments
Closed
4 tasks done

Ripple: Set primary/secondary color #322

trimox opened this issue Oct 26, 2017 · 5 comments
Assignees

Comments

@trimox
Copy link
Owner

trimox commented Oct 26, 2017

Assign modifier classes that can be used for styling ripple surfaces using the configured theme's primary and secondary colors.

Reference: https://github.com/material-components/material-components-web/blob/a983c01676e7b2a9b4aa743f722588ecb2019e4f/packages/mdc-ripple/README.md#the-mdc-ripple-surface-class

  • Add primary property
  • Add secondary property
  • Update documentation
  • Include unit test
@trimox trimox self-assigned this Oct 26, 2017
@trimox trimox modified the milestones: Milestone v0.5.7, Tracker Nov 13, 2017
@trimox trimox modified the milestones: Tracker, Milestone v0.6.2 Nov 21, 2017
trimox added a commit that referenced this issue Nov 21, 2017
Assign modifier classes that can be used for styling ripple surfaces using the configured theme's primary and secondary colors.

- Add `primary` property
- Add `secondary` property
- Add `active` property

Closes #322
@devlfm
Copy link

devlfm commented Nov 22, 2017

Hi @trimox ,

Do you think it's possible also to set the size of the Ripple? it's too big on checkbox's/toogles.. maybe a condensed size?

@trimox
Copy link
Owner Author

trimox commented Nov 22, 2017

@devlfm Are you looking for ripple size similar to the disabledRipple checkbox example?

https://trimox.github.io/angular-mdc-web/#/checkbox-demo

@devlfm
Copy link

devlfm commented Nov 22, 2017

On size yes! but on that sample it stays visible until gets focus out somewhere.. Is that intentional?

@trimox
Copy link
Owner Author

trimox commented Feb 7, 2018

@devlfm I didn't forget. Next release has smaller ripples ;)

checkbox

@devlfm
Copy link

devlfm commented Feb 8, 2018

Thank you! that awesome 🥇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants