This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 85
feat(tabs): Add disabled tab + improvements #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
========================================
+ Coverage 92.6% 92.9% +0.3%
========================================
Files 90 90
Lines 4910 4992 +82
Branches 903 916 +13
========================================
+ Hits 4547 4638 +91
+ Misses 363 354 -9
Continue to review full report at Codecov.
|
Closed
All set. Finishing up some demo examples and will merge. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disabled
tab[active]
property changes not propagating Active mdc-tab #349mdc-tab-bar-scroller__indicator
misplaced issue mdc-tab-bar-scroller__indicator misplaced #281mdc-tab-bar-scroll-button
directivemdc-tab
disabled: boolean
property tomdc-tab
active
propertychangeDetection: ChangeDetectionStrategy.OnPush
preserveWhitespaces: false
getComputedWidth(): number
; return the computed width for tab.getComputedLeft(): number
; return the computed left offset for tab.isActive()
return true if tab is active.setActive(boolean)
; set tab active property to value passed.getPreventDefaultOnClick(): boolean
; return true if the tab prevents the default click action.setPreventDefaultOnClick(boolean)
; sets tabspreventDefaultOnClick
property to the value passed.measureSelf()
; sets computedWidth and computedLeft for a tab.mdc-tab-bar
getComputedWidth(): number
layout(): void
changeDetection: ChangeDetectionStrategy.OnPush
preserveWhitespaces: false
getActiveTabIndex(): number
switchToTabAtIndex(index: number, shouldNotify: boolean = true)
MdcTabBarIndicator
directivesetPreventDefaultOnClickForTabAtIndex(index: number, preventDefaultOnClick: boolean)
isDefaultPreventedOnClickForTabAtIndex(index: number): boolean
mdc-tab-bar-scroller
layout()
changeDetection: ChangeDetectionStrategy.OnPush
preserveWhitespaces: false
scrollBack(event?: Event)
scrollForward(event?: Event)
mdc-tab-bar-scroll-button
directiveBREAKING CHANGE: Removed
mdc-tab-bar-scroll-button
directive. Usemdc-icon
instead. Please update your code accordingly.Example:
Closes #349 Closes #147 Closes #281