Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

feat(menu): Add selected property to menu items #665

Merged
merged 2 commits into from
Feb 14, 2018
Merged

feat(menu): Add selected property to menu items #665

merged 2 commits into from
Feb 14, 2018

Conversation

trimox
Copy link
Owner

@trimox trimox commented Feb 14, 2018

Change as per material-components-web v0.30.0
reference: material-components/material-components-web#2084

Adds mdc-list-item--selected class to menu items when rememberSelection is set to true.

New Public methods

  • Add setRememberSelection(rememberSelection: boolean)
  • Add getSelectedIndex(): number
  • Add setSelectedIndex(index): void
  • Add setMaxHeight(height: number): void

Closes #618

@codecov
Copy link

codecov bot commented Feb 14, 2018

Codecov Report

Merging #665 into master will increase coverage by 0.45%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
+ Coverage   91.89%   92.35%   +0.45%     
==========================================
  Files         156      156              
  Lines        6011     6027      +16     
  Branches      966      966              
==========================================
+ Hits         5524     5566      +42     
+ Misses        487      461      -26
Impacted Files Coverage Δ
src/lib/menu/menu-module.ts 100% <100%> (ø) ⬆️
src/lib/menu/menu.ts 91.36% <70%> (+10.97%) ⬆️
src/lib/snackbar/snackbar.component.ts 91.48% <0%> (+3.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf1c71...60b1020. Read the comment docs.

Also, improve test coverage
@trimox trimox merged commit 25be411 into master Feb 14, 2018
@trimox trimox deleted the menu/update branch February 14, 2018 01:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant