Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

chore(text-field): Remove ripple class for outlined text-field #754

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

trimox
Copy link
Owner

@trimox trimox commented Mar 8, 2018

As per recent upstream decision.

Justifications:

  • It's awkward to see a ripple when clicking/tapping inside an already-focused text field with the sole intent of relocating the cursor or selecting text
  • There are already enough other visual indicators, e.g. the line ripple (which also animates based on the pointer's X coordinate), and the addition of focus shade when initially focusing a text field

reference: material-components/material-components-web#2354

@trimox trimox added the new-mdc-feature Feature incorporated from material-components-web label Mar 8, 2018
@trimox trimox added this to the v0.32.0 milestone Mar 8, 2018
@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #754 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
- Coverage   92.48%   92.47%   -0.01%     
==========================================
  Files         155      155              
  Lines        6145     6140       -5     
  Branches      946      946              
==========================================
- Hits         5683     5678       -5     
  Misses        462      462
Impacted Files Coverage Δ
src/lib/textfield/outline.ts 84.61% <100%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2158f0...76bffb7. Read the comment docs.

@trimox trimox merged commit 6ed2887 into master Mar 8, 2018
@trimox trimox deleted the outline/remove-ripple branch March 8, 2018 01:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-mdc-feature Feature incorporated from material-components-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant