Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo app in Vue #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Demo app in Vue #84

wants to merge 1 commit into from

Conversation

asharghi
Copy link

@asharghi asharghi commented Sep 2, 2019

Added a demo app in Vue as promised in #83

@RobertGardner
Copy link
Collaborator

Thanks for doing this!

app.js seems to be missing (.gitignore ignores all .js files unless they are explicitly added)

In src/package.json you should add these scripts:

    "demo-vue.ios": "npm run tsc && cd ../demo-vue && tns run ios --emulator",
    "demo-vue.ios.min": "npm run tsc && cd ../demo-vue && tns run ios --env.uglify --emulator",
    "demo-vue.ios.ci": "npm run tsc && cd ../demo-vue && tns build ios --env.uglify",
    "demo-vue.android": "npm run tsc && cd ../demo-vue && tns run android --emulator",
    "demo-vue.reset": "cd ../demo-vue && npx rimraf -- hooks node_modules platforms package-lock.json",

and change the clean script to:

    "clean": "npm run demo.reset && npm run demo-angular.reset && npm run demo-vue.reset && npx rimraf -- node_modules package-lock.json && npm i",

Making those changes, I was able to get this demo to run. Cool!

One enhancement I'd like to see before merging, though, is to display the currently selected Payment Type, Shipping Method, and Total since otherwise it's confusing. (Displaying the info in the Debug area as is done in the other demos would be nice, too.) Finally, the price (to the right of Something to Buy) is off by 100. (The price is in pennies.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants