Add templating support in additionalConfigFiles

trinodb · Oct 3, 2024 · ece02db · ece02db
1 parent 476af36
commit ece02db
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/charts/trino/README.md b/charts/trino/README.md
@@ -472,11 +472,11 @@ Fast distributed SQL query engine for big data analytics that helps you explore
 * `coordinator.affinity` - object, default: `{}`
 * `coordinator.additionalConfigFiles` - object, default: `{}`  
 
-  Additional config files placed in the default configuration directory.
+  Additional config files placed in the default configuration directory. Supports templating the files' contents with `tpl`.
   Example:
   ```yaml
   secret.txt: |
-    secret-value
+    secret-value={{- .Values.someValue }}
   ```
 * `coordinator.additionalVolumes` - list, default: `[]`  
 
@@ -588,11 +588,11 @@ Fast distributed SQL query engine for big data analytics that helps you explore
 * `worker.affinity` - object, default: `{}`
 * `worker.additionalConfigFiles` - object, default: `{}`  
 
-  Additional config files placed in the default configuration directory.
+  Additional config files placed in the default configuration directory. Supports templating the files' contents with `tpl`.
   Example:
   ```yaml
   secret.txt: |
-    secret-value
+    secret-value={{- .Values.someValue }}
   ```
 * `worker.additionalVolumes` - list, default: `[]`  
 

diff --git a/charts/trino/templates/configmap-coordinator.yaml b/charts/trino/templates/configmap-coordinator.yaml
@@ -149,7 +149,7 @@ data:
 
 {{- range $fileName, $fileContent := .Values.coordinator.additionalConfigFiles }}
   {{ $fileName }}: |
-    {{- $fileContent | nindent 4 }}
+    {{- tpl $fileContent $ | nindent 4 }}
 {{- end }}
 {{- if .Values.resourceGroups }}
 ---

diff --git a/charts/trino/templates/configmap-worker.yaml b/charts/trino/templates/configmap-worker.yaml
@@ -102,7 +102,7 @@ data:
 
 {{- range $fileName, $fileContent := .Values.worker.additionalConfigFiles }}
   {{ $fileName }}: |
-    {{- $fileContent | nindent 4 }}
+    {{- tpl $fileContent $ | nindent 4 }}
 {{- end }}
 ---
 apiVersion: v1

diff --git a/charts/trino/values.yaml b/charts/trino/values.yaml
@@ -545,11 +545,12 @@ coordinator:
 
   additionalConfigFiles: {}
   # coordinator.additionalConfigFiles -- Additional config files placed in the default configuration directory.
+  # Supports templating the files' contents with `tpl`.
   # @raw
   # Example:
   # ```yaml
   # secret.txt: |
-  #   secret-value
+  #   secret-value={{- .Values.someValue }}
   # ```
 
   additionalVolumes: []
@@ -708,11 +709,12 @@ worker:
 
   additionalConfigFiles: {}
   # worker.additionalConfigFiles -- Additional config files placed in the default configuration directory.
+  # Supports templating the files' contents with `tpl`.
   # @raw
   # Example:
   # ```yaml
   # secret.txt: |
-  #   secret-value
+  #   secret-value={{- .Values.someValue }}
   # ```
 
   additionalVolumes: []