Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_separate_group.db_secret #230

Closed

Conversation

vladimir4862
Copy link
Contributor

Hello!
I'm not very experienced with Trino configuration, but I do have a bit more experience with Helm charts.
The main question in this PR is determining the correct place to change the file.password-file and file.group-file configurations.

I placed them in a separate folder to keep automatic updates when k8s secrets are updated.
This approach contrasts with using subPath, which does not support automatic file updates within pod volumes.

I was inspired by the issue
So maybe @robertpikmets also whant to look at this.

Copy link

cla-bot bot commented Sep 27, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: valdimir.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@vladimir4862
Copy link
Contributor Author

@cla-bot check

Copy link

cla-bot bot commented Sep 27, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: valdimir.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Sep 27, 2024

The cla-bot has been summoned, and re-checked this pull request!

@vladimir4862 vladimir4862 deleted the add_separate_group.db_secret branch September 27, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant