Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in Trino JMX documentation #276

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Fixed typo in Trino JMX documentation #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65b6d20
Fixed typo in Trino JMX documentation
sdaberdaku Dec 12, 2024
d7933a1
Fixing JMX docker image tag to latest working version
sdaberdaku Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/trino/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,7 +714,7 @@ Fast distributed SQL query engine for big data analytics that helps you explore
* `jmx.exporter.enabled` - bool, default: `false`

Set to true to export JMX Metrics via HTTP for [Prometheus](https://github.com/prometheus/jmx_exporter) consumption
* `jmx.exporter.image` - string, default: `"bitnami/jmx-exporter:latest"`
* `jmx.exporter.image` - string, default: `"bitnami/jmx-exporter:1.0.1"`
* `jmx.exporter.pullPolicy` - string, default: `"Always"`
* `jmx.exporter.port` - int, default: `5556`
* `jmx.exporter.configProperties` - string, default: `""`
Expand Down Expand Up @@ -764,7 +764,7 @@ Fast distributed SQL query engine for big data analytics that helps you explore
coordinator:
enabled: true
exporter:
enable: true
enabled: true
configProperties: |-
hostPort: localhost:{{- .Values.jmx.registryPort }}
startDelaySeconds: 0
Expand All @@ -778,7 +778,7 @@ Fast distributed SQL query engine for big data analytics that helps you explore
worker:
enabled: true
exporter:
enable: true
enabled: true
```
* `serviceMonitor.enabled` - bool, default: `false`

Expand Down
6 changes: 3 additions & 3 deletions charts/trino/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,7 @@ jmx:
exporter:
# jmx.exporter.enabled -- Set to true to export JMX Metrics via HTTP for [Prometheus](https://github.com/prometheus/jmx_exporter) consumption
enabled: false
image: bitnami/jmx-exporter:latest
image: bitnami/jmx-exporter:1.0.1
pullPolicy: Always
port: 5556
configProperties: ""
Expand Down Expand Up @@ -927,7 +927,7 @@ jmx:
# coordinator:
# enabled: true
# exporter:
# enable: true
# enabled: true
# configProperties: |-
# hostPort: localhost:{{- .Values.jmx.registryPort }}
# startDelaySeconds: 0
Expand All @@ -941,7 +941,7 @@ jmx:
# worker:
# enabled: true
# exporter:
# enable: true
# enabled: true
# ```

serviceMonitor:
Expand Down
2 changes: 1 addition & 1 deletion tests/trino/test-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ jmx:
serverPort: 9081
exporter:
enabled: true
image: bitnami/jmx-exporter:latest
image: bitnami/jmx-exporter:1.0.1
pullPolicy: Always
port: 5556
configProperties: |
Expand Down
Loading