Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dbapi PEP 249 errors #204

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Use dbapi PEP 249 errors #204

merged 3 commits into from
Jul 20, 2022

Conversation

mdesmet
Copy link
Contributor

@mdesmet mdesmet commented Jul 19, 2022

Fixes #199

@cla-bot cla-bot bot added the cla-signed label Jul 19, 2022
@mdesmet mdesmet changed the title Pep249 errors Use dbapi PEP 249 errors Jul 19, 2022
@mdesmet mdesmet requested review from hashhar and ebyhr July 19, 2022 21:49
hashhar
hashhar approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last commit was confusing to review - hopefully someday git will be smart enough

@ebyhr ebyhr merged commit 748d197 into trinodb:master Jul 20, 2022
@ebyhr
Copy link
Member

ebyhr commented Jul 20, 2022

Merged, thanks!

@john-bodley john-bodley mentioned this pull request Aug 4, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

@ebyhr ebyhr ebyhr approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DB API raises exceptions which are not derived from the PEP 249 database API specification
3 participants
@mdesmet @ebyhr @hashhar