Delay removal of containers during Docker image tests

trinodb · Feb 14, 2022 · 3434780 · 3434780
1 parent 6047480
commit 3434780
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/core/docker/container-test.sh b/core/docker/container-test.sh
@@ -1,6 +1,6 @@
 function cleanup {
     if [[ ! -z ${CONTAINER_ID:-} ]]; then
-        docker stop "${CONTAINER_ID}"
+        docker rm -f "${CONTAINER_ID}"
     fi
 }
 
@@ -13,7 +13,8 @@ function test_trino_starts {
 
     local CONTAINER_NAME=$1
     local PLATFORM=$2
-    CONTAINER_ID=$(docker run -d --rm --platform ${PLATFORM} "${CONTAINER_NAME}")
+    # We aren't passing --rm here to make sure container is available for inspection in case of failures
+    CONTAINER_ID=$(docker run -d --platform ${PLATFORM} "${CONTAINER_NAME}")
 
     set +e
     I=0