Extract TestUnscaledDecimal128Arithmetic#assertAdd method

trinodb · Oct 18, 2021 · 85daec7 · 85daec7
1 parent 550587f
commit 85daec7
Showing 1 changed file with 22 additions and 17 deletions.
diff --git a/core/trino-spi/src/test/java/io/trino/spi/type/TestUnscaledDecimal128Arithmetic.java b/core/trino-spi/src/test/java/io/trino/spi/type/TestUnscaledDecimal128Arithmetic.java
@@ -150,23 +150,23 @@ public void testRescaleOverflows()
     @Test
     public void testAdd()
     {
-        assertEquals(add(unscaledDecimal(0), unscaledDecimal(0)), unscaledDecimal(0));
-        assertEquals(add(unscaledDecimal(1), unscaledDecimal(0)), unscaledDecimal(1));
-        assertEquals(add(unscaledDecimal(1), unscaledDecimal(1)), unscaledDecimal(2));
-        assertEquals(add(unscaledDecimal(-1), unscaledDecimal(0)), unscaledDecimal(-1));
-        assertEquals(add(unscaledDecimal(-1), unscaledDecimal(-1)), unscaledDecimal(-2));
-        assertEquals(add(unscaledDecimal(-1), unscaledDecimal(1)), unscaledDecimal(0));
-        assertEquals(add(unscaledDecimal(1), unscaledDecimal(-1)), unscaledDecimal(0));
-        assertEquals(add(unscaledDecimal("10000000000000000000000000000000000000"), unscaledDecimal(0)), unscaledDecimal("10000000000000000000000000000000000000"));
-        assertEquals(add(unscaledDecimal("10000000000000000000000000000000000000"), unscaledDecimal("10000000000000000000000000000000000000")), unscaledDecimal("20000000000000000000000000000000000000"));
-        assertEquals(add(unscaledDecimal("-10000000000000000000000000000000000000"), unscaledDecimal(0)), unscaledDecimal("-10000000000000000000000000000000000000"));
-        assertEquals(add(unscaledDecimal("-10000000000000000000000000000000000000"), unscaledDecimal("-10000000000000000000000000000000000000")), unscaledDecimal("-20000000000000000000000000000000000000"));
-        assertEquals(add(unscaledDecimal("-10000000000000000000000000000000000000"), unscaledDecimal("10000000000000000000000000000000000000")), unscaledDecimal(0));
-        assertEquals(add(unscaledDecimal("10000000000000000000000000000000000000"), unscaledDecimal("-10000000000000000000000000000000000000")), unscaledDecimal(0));
-
-        assertEquals(add(unscaledDecimal(1L << 32), unscaledDecimal(0)), unscaledDecimal(1L << 32));
-        assertEquals(add(unscaledDecimal(1L << 31), unscaledDecimal(1L << 31)), unscaledDecimal(1L << 32));
-        assertEquals(add(unscaledDecimal(1L << 32), unscaledDecimal(1L << 33)), unscaledDecimal((1L << 32) + (1L << 33)));
+        assertAdd(unscaledDecimal(0), unscaledDecimal(0), unscaledDecimal(0));
+        assertAdd(unscaledDecimal(1), unscaledDecimal(0), unscaledDecimal(1));
+        assertAdd(unscaledDecimal(1), unscaledDecimal(1), unscaledDecimal(2));
+        assertAdd(unscaledDecimal(-1), unscaledDecimal(0), unscaledDecimal(-1));
+        assertAdd(unscaledDecimal(-1), unscaledDecimal(-1), unscaledDecimal(-2));
+        assertAdd(unscaledDecimal(-1), unscaledDecimal(1), unscaledDecimal(0));
+        assertAdd(unscaledDecimal(1), unscaledDecimal(-1), unscaledDecimal(0));
+        assertAdd(unscaledDecimal("10000000000000000000000000000000000000"), unscaledDecimal(0), unscaledDecimal("10000000000000000000000000000000000000"));
+        assertAdd(unscaledDecimal("10000000000000000000000000000000000000"), unscaledDecimal("10000000000000000000000000000000000000"), unscaledDecimal("20000000000000000000000000000000000000"));
+        assertAdd(unscaledDecimal("-10000000000000000000000000000000000000"), unscaledDecimal(0), unscaledDecimal("-10000000000000000000000000000000000000"));
+        assertAdd(unscaledDecimal("-10000000000000000000000000000000000000"), unscaledDecimal("-10000000000000000000000000000000000000"), unscaledDecimal("-20000000000000000000000000000000000000"));
+        assertAdd(unscaledDecimal("-10000000000000000000000000000000000000"), unscaledDecimal("10000000000000000000000000000000000000"), unscaledDecimal(0));
+        assertAdd(unscaledDecimal("10000000000000000000000000000000000000"), unscaledDecimal("-10000000000000000000000000000000000000"), unscaledDecimal(0));
+
+        assertAdd(unscaledDecimal(1L << 32), unscaledDecimal(0), unscaledDecimal(1L << 32));
+        assertAdd(unscaledDecimal(1L << 31), unscaledDecimal(1L << 31), unscaledDecimal(1L << 32));
+        assertAdd(unscaledDecimal(1L << 32), unscaledDecimal(1L << 33), unscaledDecimal((1L << 32) + (1L << 33)));
     }
 
     @Test
@@ -552,6 +552,11 @@ public void testShiftLeft()
         assertEquals(shiftLeft(wrappedLongArray(0x1L, 0L), 64 + 63), wrappedLongArray(0x0000000000000000L, 0x8000000000000000L));
     }
 
+    private void assertAdd(Slice left, Slice right, Slice result)
+    {
+        assertEquals(add(left, right), result);
+    }
+
     private void assertAddReturnOverflow(BigInteger left, BigInteger right)
     {
         Slice result = unscaledDecimal();