-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enable failure recovery for Iceberg connector
- Loading branch information
Showing
4 changed files
with
216 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
113 changes: 113 additions & 0 deletions
113
...n/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergFailureRecoveryTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.plugin.iceberg; | ||
|
|
||
| import io.trino.operator.RetryPolicy; | ||
| import io.trino.testing.BaseFailureRecoveryTest; | ||
| import org.intellij.lang.annotations.Language; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Optional; | ||
|
|
||
| import static java.lang.String.format; | ||
| import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy; | ||
|
|
||
| public abstract class BaseIcebergFailureRecoveryTest | ||
| extends BaseFailureRecoveryTest | ||
| { | ||
| protected BaseIcebergFailureRecoveryTest(RetryPolicy retryPolicy) | ||
| { | ||
| super(retryPolicy); | ||
| } | ||
|
|
||
| @Override | ||
| protected boolean areWriteRetriesSupported() | ||
| { | ||
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public void testAnalyzeStatistics() | ||
| { | ||
| assertThatThrownBy(super::testAnalyzeStatistics) | ||
| .hasMessageContaining("This connector does not support analyze"); | ||
| } | ||
|
|
||
| @Override | ||
| public void testDelete() | ||
| { | ||
| assertThatThrownBy(super::testDelete) | ||
| .hasMessageContaining("This connector only supports delete where one or more identity-transformed partitions are deleted entirely"); | ||
| } | ||
|
|
||
| @Override | ||
| public void testDeleteWithSubquery() | ||
| { | ||
| assertThatThrownBy(super::testDelete) | ||
| .hasMessageContaining("This connector only supports delete where one or more identity-transformed partitions are deleted entirely"); | ||
| } | ||
|
|
||
| @Override | ||
| protected void createPartitionedLineitemTable(String tableName, List<String> columns, String partitionColumn) | ||
| { | ||
| @Language("SQL") String sql = format( | ||
| "CREATE TABLE %s WITH (partitioning=array['%s']) AS SELECT %s FROM tpch.tiny.lineitem", | ||
| tableName, | ||
| partitionColumn, | ||
| String.join(",", columns)); | ||
| getQueryRunner().execute(sql); | ||
| } | ||
|
|
||
| @Override | ||
| public void testUpdate() | ||
| { | ||
| assertThatThrownBy(super::testUpdate) | ||
| .hasMessageContaining("This connector does not support updates"); | ||
| } | ||
|
|
||
| @Override | ||
| public void testUpdateWithSubquery() | ||
| { | ||
| assertThatThrownBy(super::testUpdateWithSubquery) | ||
| .hasMessageContaining("This connector does not support updates"); | ||
| } | ||
|
|
||
| @Test(invocationCount = INVOCATION_COUNT) | ||
| public void testCreatePartitionedTable() | ||
| { | ||
| testTableModification( | ||
| Optional.empty(), | ||
| "CREATE TABLE <table> WITH (partitioning = ARRAY['p']) AS SELECT *, 'partition1' p FROM orders", | ||
| Optional.of("DROP TABLE <table>")); | ||
| } | ||
|
|
||
| @Test(invocationCount = INVOCATION_COUNT) | ||
| public void testInsertIntoNewPartition() | ||
| { | ||
| testTableModification( | ||
| Optional.of("CREATE TABLE <table> WITH (partitioning = ARRAY['p']) AS SELECT *, 'partition1' p FROM orders"), | ||
| "INSERT INTO <table> SELECT *, 'partition2' p FROM orders", | ||
| Optional.of("DROP TABLE <table>")); | ||
| } | ||
|
|
||
| @Test(invocationCount = INVOCATION_COUNT) | ||
| public void testInsertIntoExistingPartition() | ||
| { | ||
| testTableModification( | ||
| Optional.of("CREATE TABLE <table> WITH (partitioning = ARRAY['p']) AS SELECT *, 'partition1' p FROM orders"), | ||
| "INSERT INTO <table> SELECT *, 'partition1' p FROM orders", | ||
| Optional.of("DROP TABLE <table>")); | ||
| } | ||
| } |
41 changes: 41 additions & 0 deletions
41
...no-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergQueryFailureRecoveryTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.plugin.iceberg; | ||
|
|
||
| import io.trino.operator.RetryPolicy; | ||
| import io.trino.testing.QueryRunner; | ||
| import io.trino.tpch.TpchTable; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class TestIcebergQueryFailureRecoveryTest | ||
| extends BaseIcebergFailureRecoveryTest | ||
| { | ||
| protected TestIcebergQueryFailureRecoveryTest() | ||
| { | ||
| super(RetryPolicy.QUERY); | ||
| } | ||
|
|
||
| @Override | ||
| protected QueryRunner createQueryRunner(List<TpchTable<?>> requiredTpchTables, Map<String, String> configProperties, Map<String, String> coordinatorProperties) | ||
| throws Exception | ||
| { | ||
| return IcebergQueryRunner.builder() | ||
| .setInitialTables(requiredTpchTables) | ||
| .setCoordinatorProperties(coordinatorProperties) | ||
| .setExtraProperties(configProperties) | ||
| .build(); | ||
| } | ||
| } |
55 changes: 55 additions & 0 deletions
55
...ino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergTaskFailureRecoveryTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.plugin.iceberg; | ||
|
|
||
| import com.google.common.collect.ImmutableMap; | ||
| import io.trino.operator.RetryPolicy; | ||
| import io.trino.testing.QueryRunner; | ||
| import io.trino.tpch.TpchTable; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
|
|
||
| public class TestIcebergTaskFailureRecoveryTest | ||
| extends BaseIcebergFailureRecoveryTest | ||
| { | ||
| protected TestIcebergTaskFailureRecoveryTest() | ||
| { | ||
| super(RetryPolicy.TASK); | ||
| } | ||
|
|
||
| @Override | ||
| protected QueryRunner createQueryRunner(List<TpchTable<?>> requiredTpchTables, Map<String, String> configProperties, Map<String, String> coordinatorProperties) | ||
| throws Exception | ||
| { | ||
| return IcebergQueryRunner.builder() | ||
| .setInitialTables(requiredTpchTables) | ||
| .setCoordinatorProperties(coordinatorProperties) | ||
| .setExtraProperties(ImmutableMap.<String, String>builder() | ||
| .putAll(configProperties) | ||
| // currently not supported for fault tolerant execution mode | ||
| .put("enable-dynamic-filtering", "false") | ||
| .build()) | ||
| .build(); | ||
| } | ||
|
|
||
| @Override | ||
| public void testJoinDynamicFilteringEnabled() | ||
| { | ||
| assertThatThrownBy(super::testJoinDynamicFilteringEnabled) | ||
| .hasMessageContaining("Dynamic filtering is not supported with automatic task retries enabled"); | ||
| } | ||
| } |