Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase OrcReader#MAX_BATCH_SIZE to 8196 #10575

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Increase OrcReader#MAX_BATCH_SIZE to 8196 #10575

merged 1 commit into from
Jan 31, 2022

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Jan 12, 2022

No description provided.

@sopel39 sopel39 requested a review from martint January 12, 2022 14:24
@cla-bot cla-bot bot added the cla-signed label Jan 12, 2022
@sopel39 sopel39 changed the title Increase OrcReader#MAX_BATCH_SIZE to 8048 Increase OrcReader#MAX_BATCH_SIZE to 8196 Jan 13, 2022
@sopel39 sopel39 force-pushed the ks/orc_increase_batch_size branch from 23068c2 to 2286d4c Compare January 13, 2022 09:43
@sopel39 sopel39 force-pushed the ks/orc_increase_batch_size branch from 2286d4c to cca2ae4 Compare January 14, 2022 09:57
@sopel39 sopel39 force-pushed the ks/orc_increase_batch_size branch from cca2ae4 to 695a222 Compare January 29, 2022 22:24
@sopel39
Copy link
Member Author

sopel39 commented Jan 31, 2022

ORC unpart

  label TPCH wall time TPC-DS wall time TPCH CPU time TPC-DS CPU time TPCH peak mem TPC-DS peak mem
baseline 750.309333 1794.496333 99157.1 238948.688000 2.063479e+09 1.127753e+09
orc 8k unpart 737.433500 1746.449500 95702.4 229404.482167 2.078884e+09 1.123496e+09

ORC part

label TPCH wall time TPC-DS wall time TPCH CPU time TPC-DS CPU time TPCH peak mem TPC-DS peak mem
baseine 833.860667 1143.438667 111812.3 133595.615000 2.127303e+09 1.246159e+09
orc 8k part 815.746833 1106.233500 110167.1 127751.651667 2.144631e+09 1.246598e+09

@sopel39 sopel39 requested review from kokosing and findepi January 31, 2022 09:35
@sopel39 sopel39 merged commit 35ce779 into trinodb:master Jan 31, 2022
@github-actions github-actions bot added this to the 370 milestone Jan 31, 2022
@sopel39 sopel39 mentioned this pull request Jan 31, 2022
Closed
@kokosing kokosing deleted the ks/orc_increase_batch_size branch January 31, 2022 10:09
@mosabua mosabua mentioned this pull request Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raunaqmorarka raunaqmorarka raunaqmorarka left review comments

@Praveen2112 Praveen2112 Praveen2112 left review comments

@kokosing kokosing kokosing approved these changes

@martint martint Awaiting requested review from martint

@findepi findepi Awaiting requested review from findepi

Assignees
No one assigned
Labels
cla-signed
Milestone
370
Development

Successfully merging this pull request may close these issues.
4 participants
@sopel39 @raunaqmorarka @kokosing @Praveen2112