Fix ClassCastException in DomainTranslator #14958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
approved these changes
Nov 11, 2022
Did you mean |
findepi
approved these changes
Nov 14, 2022
| @@ -1083,6 +1083,23 @@ public void testPredicateWithVarcharCastToDate() | |||
| and( | |||
| greaterThanOrEqual(cast(C_VARCHAR, DATE), new GenericLiteral("DATE", "2001-01-31")), | |||
| lessThanOrEqual(cast(C_VARCHAR, DATE), new GenericLiteral("DATE", "2005-09-10")))); | |||
|
|
|||
| assertPredicateTranslates( | |||
There was a problem hiding this comment.
Add a comment what's special about this case.
findepi
reviewed
Nov 14, 2022
core/trino-main/src/main/java/io/trino/sql/planner/DomainTranslator.java
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/TestDomainTranslator.java
Show resolved
Hide resolved
When theres's an expression such as:
CAST('2022-01-01') AS date) BETWEEN CAST(start_date AS date) AND CAST(end_date AS date)
There's a call to visitComparisonExpression with the term:
DATE '2022-01-01' >= CAST(start_date AS date)
Inside that method, the expression is normalized to have the symbol on the
left and the constant on the right. However, the createVarcharCastToDateComparisonExtractionResult
pulls the elements from the unnormalized ComparisonExpression node and expects the left
subexpression to be cast, which results in a failure due to ClassCastException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When theres's an expression such as:
There's a call to visitComparisonExpression with the term:
Inside that method, the expression is normalized to have the symbol on the left and the constant on the right. However, the createVarcharCastToDateComparisonExtractionResult pulls the elements from the unnormalized ComparisonExpression node and expects the left subexpression to be cast, which results in a failure due to ClassCastException
Fixes #14954
Release notes
(x) Release notes are required, with the following suggested text: